Bug 203616 – REGRESSION (r251750): Three CSS Tests are Failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Russell Epstein]

The following three tests are failing after the changes in r251750:

fast/css/hsl-color.html
fast/css/hsla-color.html
http/wpt/css/css-images-4/conic-gradient-parsing.html

Test History:

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Fwpt%2Fcss%2Fcss-images-4%2Fconic-gradient-parsing.html&test=fast%2Fcss%2Fhsl-color.html&test=fast%2Fcss%2Fhsla-color.html

Steps to Reproduce:

run-webkit-tests --ios-simulator --no-retry http/wpt/css/css-images-4/conic-gradient-parsing.html fast/css/hsl-color.html fast/css/hsla-color.html

Diffs:
--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/css/hsl-color-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/css/hsl-color-actual.txt
@@ -15,13 +15,13 @@
       RenderBlock {H1} at (0,178) size 784x39 [color=#0000FF]
         RenderText {#text} at (0,1) size 570x36
           text run at (0,1) width 570: "This should be blue: hsl(240, 100%, 50%)"
-      RenderBlock {H1} at (0,237) size 784x39 [color=#7FFF7F]
+      RenderBlock {H1} at (0,237) size 784x39 [color=#80FF80]
         RenderText {#text} at (0,1) size 657x36
           text run at (0,1) width 657: "This should be light green: hsl(120, 100%, 75%)"
-      RenderBlock {H1} at (0,297) size 784x39 [color=#007F00]
+      RenderBlock {H1} at (0,297) size 784x39 [color=#008000]
         RenderText {#text} at (0,1) size 660x36
           text run at (0,1) width 660: "This should be dark green: hsl(120, 100%, 25%)"
-      RenderBlock {H1} at (0,356) size 784x39 [color=#3FBF3F]
+      RenderBlock {H1} at (0,356) size 784x39 [color=#40BF40]
         RenderText {#text} at (0,1) size 659x36
           text run at (0,1) width 659: "This should be pastel green: hsl(120, 50%, 50%)"
       RenderBlock (anonymous) at (0,416) size 784x41
@@ -40,32 +40,32 @@
       RenderBlock (anonymous) at (0,596) size 784x21
         RenderText {#text} at (0,0) size 480x19
           text run at (0,0) width 480: "Check percentages less than 0% (negative values), should be limited to 0%"
-      RenderBlock {H1} at (0,637) size 784x39 [color=#7F7F7F]
+      RenderBlock {H1} at (0,637) size 784x39 [color=#808080]
         RenderText {#text} at (0,1) size 539x36
           text run at (0,1) width 539: "This should be grey: hsl(120, 0%, 50%)"
-      RenderBlock {H1} at (0,697) size 784x39 [color=#7F7F7F]
+      RenderBlock {H1} at (0,697) size 784x39 [color=#808080]
         RenderText {#text} at (0,1) size 638x36
           text run at (0,1) width 638: "This should be grey, too: hsl(120, -100%, 50%)"
       RenderBlock (anonymous) at (0,756) size 784x41
         RenderText {#text} at (0,0) size 781x39
           text run at (0,0) width 781: "Check Hue values that are larger than 360, should be normalized back to a value between 0 and 360. As Hue values are in"
           text run at (0,20) width 444: "degrees, there is no maximum like percentages, they are loop around."
-      RenderBlock {H1} at (0,818) size 784x39 [color=#007F00]
+      RenderBlock {H1} at (0,818) size 784x39 [color=#008000]
         RenderText {#text} at (0,1) size 660x36
           text run at (0,1) width 660: "This should be dark green: hsl(120, 100%, 25%)"
-      RenderBlock {H1} at (0,877) size 784x39 [color=#007F00]
+      RenderBlock {H1} at (0,877) size 784x39 [color=#008000]
         RenderText {#text} at (0,1) size 719x36
           text run at (0,1) width 719: "This should be dark green, too: hsl(480, 100%, 25%)"
       RenderBlock (anonymous) at (0,937) size 784x20
         RenderText {#text} at (0,0) size 261x19
           text run at (0,0) width 261: "Check Hue values with a negative angle."
-      RenderBlock {H1} at (0,978) size 784x39 [color=#7FFF7F]
+      RenderBlock {H1} at (0,978) size 784x39 [color=#80FF80]
         RenderText {#text} at (0,1) size 657x36
           text run at (0,1) width 657: "This should be light green: hsl(120, 100%, 75%)"
-      RenderBlock {H1} at (0,1037) size 784x39 [color=#7FFF7F]
+      RenderBlock {H1} at (0,1037) size 784x39 [color=#80FF80]
         RenderText {#text} at (0,1) size 726x36
           text run at (0,1) width 726: "This should be light green, too: hsl(-240, 100%, 75%)"
-      RenderBlock {H1} at (0,1097) size 784x39 [color=#7FFF7F]
+      RenderBlock {H1} at (0,1097) size 784x39 [color=#80FF80]
         RenderText {#text} at (0,1) size 726x36
           text run at (0,1) width 726: "This should be light green, too: hsl(-600, 100%, 75%)"
       RenderBlock (anonymous) at (0,1156) size 784x21

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/css/hsla-color-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/css/hsla-color-actual.txt
@@ -3,10 +3,10 @@
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
     RenderBody {BODY} at (8,8) size 784x571 [bgcolor=#FFFF00]
-      RenderBlock {H1} at (0,0) size 784x38 [color=#FF00007F]
+      RenderBlock {H1} at (0,0) size 784x38 [color=#FF000080]
         RenderText {#text} at (0,1) size 394x36
           text run at (0,1) width 394: "This should be red, alpha 0.5"
-      RenderBlock {H1} at (0,59) size 784x39 [color=#FF00007F]
+      RenderBlock {H1} at (0,59) size 784x39 [color=#FF000080]
         RenderText {#text} at (0,1) size 455x36
           text run at (0,1) width 455: "This should also be red, alpha 0.5"
       RenderBlock {H1} at (0,118) size 784x39 [color=#00FF0000]

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/wpt/css/css-images-4/conic-gradient-parsing-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/wpt/css/css-images-4/conic-gradient-parsing-actual.txt
@@ -1,4 +1,4 @@
 
-PASS Test conic-gradient parsing 
+FAIL Test conic-gradient parsing assert_equals: Testing round trip of conic-gradient(hsl(0,0%,75%), hsl(0,0%,25%)) expected "conic-gradient(rgb(191, 191, 191), rgb(63, 63, 63))" but got "conic-gradient(rgb(191, 191, 191), rgb(64, 64, 64))"
 PASS Test repeating-conic-gradient parsing

[Radar WebKit Bug Importer]

<rdar://problem/56749907>

[Simon Fraser (smfr)]

https://bugs.webkit.org/show_bug.cgi?id=203616

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/251804/webkit