Bug 203580

Summary: [EME] Batch multiple key requests into one request and response
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
Patch
none
Patch
none
Archive of layout-test-results from ews212 for win-future
none
Patch
none
Patch for landing none

Jer Noble
Reported 2019-10-29 12:52:21 PDT
[EME] Batch multiple key requests into one request and response
Attachments
WIP (34.86 KB, patch)
2019-10-29 13:56 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
WIP (34.89 KB, patch)
2019-10-29 14:14 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (36.64 KB, patch)
2019-10-29 16:41 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (37.04 KB, patch)
2019-10-29 17:11 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (14.31 MB, application/zip)
2019-10-29 21:26 PDT, EWS Watchlist 		no flags
Details
Patch (37.12 KB, patch)
2019-10-31 10:44 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.11 KB, patch)
2019-10-31 16:09 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2019-10-29 13:34:54 PDT
<rdar://problem/54853345>
Jer Noble
Comment 2 2019-10-29 13:56:47 PDT
Created attachment 382218 [details] WIP
Jer Noble
Comment 3 2019-10-29 14:14:26 PDT
Created attachment 382222 [details] WIP
Jer Noble
Comment 4 2019-10-29 16:41:09 PDT
Created attachment 382250 [details] Patch
Jer Noble
Comment 5 2019-10-29 17:11:11 PDT
Created attachment 382254 [details] Patch
EWS Watchlist
Comment 6 2019-10-29 21:26:11 PDT
Comment on attachment 382254 [details] Patch Attachment 382254 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13190195 New failing tests: html5lib/generated/run-tests11-data.html imported/mozilla/svg/filters/feSpecularLighting-1.svg
EWS Watchlist
Comment 7 2019-10-29 21:26:13 PDT
Created attachment 382277 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Jer Noble
Comment 8 2019-10-31 10:44:48 PDT
Created attachment 382477 [details] Patch
Eric Carlson
Comment 9 2019-10-31 14:21:17 PDT
Comment on attachment 382477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382477&action=review > Source/WebCore/ChangeLog:17 > + in m_currentRequset and m_requests, or in m_pendingRequests. Nit: m_currentRequset => m_currentRequest > Source/WebCore/ChangeLog:23 > + - There are a couple helper classes that facilitate collecting delegate callbacks and completion handlers Nit: are a couple helper => are a couple of helper > Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:536 > + // Either "payload" nor "error" are present, but not both Nit: nor => or
Jer Noble
Comment 10 2019-10-31 16:09:53 PDT
Created attachment 382515 [details] Patch for landing
WebKit Commit Bot
Comment 11 2019-10-31 16:54:47 PDT
Comment on attachment 382515 [details] Patch for landing Clearing flags on attachment: 382515 Committed r251895: <https://trac.webkit.org/changeset/251895>
WebKit Commit Bot
Comment 12 2019-10-31 16:54:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.