Bug 203567 – REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Russell Epstein]

The following two layout tests are failing on iOS after the changes landed in r251594:

http/tests/cookies/same-site/set-first-party-cross-site-cookies.php
http/tests/cookies/same-site/set-first-party-same-site-cookies.php

Steps to Reproduce:

run-webkit-tests --ios-simulator --no-retry --exit-after-n-failures 1 http/tests/cookies/same-site/set-first-party-same-site-cookies.php --iter 20

Test History:

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fcookies%2Fsame-site%2Fset-first-party-cross-site-cookies.php&test=http%2Ftests%2Fcookies%2Fsame-site%2Fset-first-party-same-site-cookies.php

Diffs:

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/cookies/same-site/set-first-party-cross-site-cookies-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/cookies/same-site/set-first-party-cross-site-cookies-actual.txt
@@ -1,15 +1,41 @@
-HTTP sent cookies:
-
-implicit-strict = 14
-lax = 14
-normal = 14
-strict = 14
-strict-because-invalid-SameSite-value = 14
-DOM cookies:
-
-implicit-strict = 14
-lax = 14
-normal = 14
-strict = 14
-strict-because-invalid-SameSite-value = 14
-
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderBR {BR} at (0,0) size 0x19
+      RenderInline {B} at (0,0) size 61x19
+        RenderText {#text} at (0,20) size 61x19
+          text run at (0,20) width 61: "Warning"
+      RenderText {#text} at (60,20) size 777x39
+        text run at (60,20) width 9: ": "
+        text run at (68,20) width 709: "Use of undefined constant _deleteCookieCallback - assumed '_deleteCookieCallback' (this will throw an Error"
+        text run at (0,40) width 194: "in a future version of PHP) in "
+      RenderInline {B} at (0,0) size 540x39
+        RenderText {#text} at (193,40) size 540x39
+          text run at (193,40) width 347: "/Volumes/Data/slave/ios-simulator-13-release-tests-"
+          text run at (0,60) width 482: "wk2/build/LayoutTests/http/tests/cookies/resources/cookie-utilities.php"
+      RenderText {#text} at (481,60) size 53x19
+        text run at (481,60) width 53: " on line "
+      RenderInline {B} at (0,0) size 17x19
+        RenderText {#text} at (533,60) size 17x19
+          text run at (533,60) width 17: "51"
+      RenderBR {BR} at (549,75) size 1x0
+      RenderBR {BR} at (0,80) size 0x19
+      RenderInline {B} at (0,0) size 61x19
+        RenderText {#text} at (0,100) size 61x19
+          text run at (0,100) width 61: "Warning"
+      RenderText {#text} at (60,100) size 732x39
+        text run at (60,100) width 9: ": "
+        text run at (68,100) width 664: "Cannot modify header information - headers already sent by (output started at /Volumes/Data/slave/ios-"
+        text run at (0,120) width 669: "simulator-13-release-tests-wk2/build/LayoutTests/http/tests/cookies/resources/cookie-utilities.php:51) in"
+      RenderInline {B} at (0,0) size 746x39
+        RenderText {#text} at (0,140) size 746x39
+          text run at (0,140) width 746: "/Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/LayoutTests/http/tests/cookies/resources/cookie-"
+          text run at (0,160) width 82: "utilities.php"
+      RenderText {#text} at (81,160) size 53x19
+        text run at (81,160) width 53: " on line "
+      RenderInline {B} at (0,0) size 17x19
+        RenderText {#text} at (133,160) size 17x19
+          text run at (133,160) width 17: "16"
+      RenderBR {BR} at (149,175) size 1x0

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/cookies/same-site/set-first-party-same-site-cookies-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/cookies/same-site/set-first-party-same-site-cookies-actual.txt
@@ -1,15 +1,41 @@
-HTTP sent cookies:
-
-implicit-strict = 14
-lax = 14
-normal = 14
-strict = 14
-strict-because-invalid-SameSite-value = 14
-DOM cookies:
-
-implicit-strict = 14
-lax = 14
-normal = 14
-strict = 14
-strict-because-invalid-SameSite-value = 14
-
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderBR {BR} at (0,0) size 0x19
+      RenderInline {B} at (0,0) size 61x19
+        RenderText {#text} at (0,20) size 61x19
+          text run at (0,20) width 61: "Warning"
+      RenderText {#text} at (60,20) size 777x39
+        text run at (60,20) width 9: ": "
+        text run at (68,20) width 709: "Use of undefined constant _deleteCookieCallback - assumed '_deleteCookieCallback' (this will throw an Error"
+        text run at (0,40) width 194: "in a future version of PHP) in "
+      RenderInline {B} at (0,0) size 540x39
+        RenderText {#text} at (193,40) size 540x39
+          text run at (193,40) width 347: "/Volumes/Data/slave/ios-simulator-13-release-tests-"
+          text run at (0,60) width 482: "wk2/build/LayoutTests/http/tests/cookies/resources/cookie-utilities.php"
+      RenderText {#text} at (481,60) size 53x19
+        text run at (481,60) width 53: " on line "
+      RenderInline {B} at (0,0) size 17x19
+        RenderText {#text} at (533,60) size 17x19
+          text run at (533,60) width 17: "51"
+      RenderBR {BR} at (549,75) size 1x0
+      RenderBR {BR} at (0,80) size 0x19
+      RenderInline {B} at (0,0) size 61x19
+        RenderText {#text} at (0,100) size 61x19
+          text run at (0,100) width 61: "Warning"
+      RenderText {#text} at (60,100) size 732x39
+        text run at (60,100) width 9: ": "
+        text run at (68,100) width 664: "Cannot modify header information - headers already sent by (output started at /Volumes/Data/slave/ios-"
+        text run at (0,120) width 669: "simulator-13-release-tests-wk2/build/LayoutTests/http/tests/cookies/resources/cookie-utilities.php:51) in"
+      RenderInline {B} at (0,0) size 746x39
+        RenderText {#text} at (0,140) size 746x39
+          text run at (0,140) width 746: "/Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/LayoutTests/http/tests/cookies/resources/cookie-"
+          text run at (0,160) width 82: "utilities.php"
+      RenderText {#text} at (81,160) size 53x19
+        text run at (81,160) width 53: " on line "
+      RenderInline {B} at (0,0) size 17x19
+        RenderText {#text} at (133,160) size 17x19
+          text run at (133,160) width 17: "16"
+      RenderBR {BR} at (149,175) size 1x0

[Radar WebKit Bug Importer]

<rdar://problem/56708500>

[Matt Lewis]

The patch was rolled out in:
https://trac.webkit.org/changeset/251710/webkit

[Russell Epstein]

Reverting 251594 did not resolve the issue. Reopening bug.

[Russell Epstein]

Marked test as failing in r251807

[Daniel Bates]

Created attachment 382383 [details]
Patch

[Daniel Bates]

Created attachment 382470 [details]
Patch

[Daniel Bates]

Thanks for the review!

[Daniel Bates]

Comment on attachment 382470 [details]
Patch

Clearing flags on attachment: 382470

Committed r252140: <https://trac.webkit.org/changeset/252140>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.