Summary: | [FreeType] Too slow running encoding/legacy-mb-korean/euc-kr WPT tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, ews-watchlist, mmaxfield, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=183210 https://bugs.webkit.org/show_bug.cgi?id=183285 |
||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2019-10-28 17:21:04 PDT
I have run perf over the WebProcess and it seems the biggest issue is by far the call to FcFontMatch inside FontCache::systemFallbackForCharacters() Another test is just loading this page https://w3c-test.org/encoding/legacy-mb-korean/euc-kr/euckr_chars-ksc5601.html and checking that it draws the characters correctly and the time it takes to load. Looking at the blame log it looked like r229164 could be related. So I checked to build WebKitGTK on r229163 and r229164 and check the load times of https://w3c-test.org/encoding/legacy-mb-korean/euc-kr/euckr_chars-ksc5601.html (from a cold start and loading the html from disk to avoid network latencies) r229163 7 seconds r229164 13 seconds r251384 30 seconds So, r229164 caused the first regression of almost a 100%, and this further regressed more after that. I still don't know which revision(s) caused the second regression, probably its worth bisecting. (In reply to Carlos Alberto Lopez Perez from comment #2) > I still don't know which revision(s) caused the second regression, probably > its worth bisecting. The one that caused this second regression (from 13 seconds to 30 seconds) it seems it was r230559 I can get the 13 seconds performance back by running minibrowser (on r251384) with the env var WEBKIT_FORCE_COMPLEX_TEXT=0 Created attachment 382440 [details]
Patch
Comment on attachment 382440 [details]
Patch
r=me
Amazing patch! Now the test takes just only 3 seconds. At least a 10x improvement! :)
Committed r252044: <https://trac.webkit.org/changeset/252044> |