Bug 203489

Summary: Python 3: Add support in webkitpy.port
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184986
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-10-28 09:17:26 PDT
webkitpy.port supports layout tests and API tests, among other things. The factory code is imported all over the place, so this turns out to be a blocker for converting the rest of webkitpy.common.
Attachments
Patch (50.51 KB, patch)
2019-10-28 09:23 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (50.39 KB, patch)
2019-10-30 12:04 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (50.46 KB, patch)
2019-10-30 14:21 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-28 09:23:40 PDT
Created attachment 382077 [details] Patch
dewei_zhu
Comment 2 2019-10-30 10:35:53 PDT
Comment on attachment 382077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382077&action=review > Tools/Scripts/webkitpy/common/version.py:122 > + result ^= hash(self[i]) This may not be accurate and easy to create a collision. For example "1.2.3.4.5" will have the same has as "5.4.3.2.1" if I understand the hash algorithm correctly here. How about using `hash(self.__str__())` or `hash(str(self))` instead?
Jonathan Bedard
Comment 3 2019-10-30 12:04:34 PDT
Created attachment 382339 [details] Patch
dewei_zhu
Comment 4 2019-10-30 14:16:51 PDT
Comment on attachment 382339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382339&action=review > Tools/ChangeLog:26 > + * Scripts/webkitpy/port/config_standalone.py: Ditto Please update the change description for this line. It was a bug before this change.
Jonathan Bedard
Comment 5 2019-10-30 14:21:00 PDT
Created attachment 382353 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-10-30 14:57:04 PDT
Comment on attachment 382353 [details] Patch for landing Clearing flags on attachment: 382353 Committed r251808: <https://trac.webkit.org/changeset/251808>
WebKit Commit Bot
Comment 7 2019-10-30 14:57:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-30 14:58:19 PDT
<rdar://problem/56759792>
Note You need to log in before you can comment on or make changes to this bug.