Bug 203481
| Summary: | Module scripts should always decode using UTF-8 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, philip, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
This fails html/semantics/scripting-1/the-script-element/module/charset-02.html in web-platform-tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
NOTE - Safari is still failing two sub-tests;
https://wpt.fyi/results/html/semantics/scripting-1/the-script-element/module/charset-02.html?label=master&label=experimental&aligned&view=subtest&q=charset-02
UTF-16 module script with UTF-16BE BOM & UTF-16 module script with UTF-16LE BOM
Radar WebKit Bug Importer
<rdar://problem/98222621>
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/8981
EWS
Committed 259251@main (c40873d23eea): <https://commits.webkit.org/259251@main>
Reviewed commits have been landed. Closing PR #8981 and removing active labels.
Ryosuke Niwa
This patch broke builds:
ld: warning: directory not found for option '-L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/local/lib'
Undefined symbols for architecture x86_64:
"WebCore::CachedScript::scriptHash(WebCore::CachedScript::ShouldDecodeAsUTF8Only)", referenced from:
WebCore::CachedScriptSourceProvider::hash() const in Internals-cd36146d9e9bd865a5d44b2d2e51c772ab2b26571f02b9a2c612ac2085f1c5da.o
"WebCore::CachedScript::script(WebCore::CachedScript::ShouldDecodeAsUTF8Only)", referenced from:
WebCore::CachedScriptSourceProvider::source() const in Internals-cd36146d9e9bd865a5d44b2d2e51c772ab2b26571f02b9a2c612ac2085f1c5da.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Ryosuke Niwa
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9015
EWS
Committed 259261@main (64dcc8c9d1ae): <https://commits.webkit.org/259261@main>
Reviewed commits have been landed. Closing PR #9015 and removing active labels.