Bug 20338 – [Gtk] Autotools should check for libxslt

• Component: WebKitGTK
• Status: RESOLVED INVALID

[Jan Alonzo]

We're not checking for libxslt and hence, missing -lxslt in the build.

[Jan Alonzo]

Created attachment 22716 [details]
check for libxslt in autotools

[Mark Rowe (bdash)]

Comment on attachment 22716 [details]
check for libxslt in autotools

r=me

[Jan Alonzo]

Thanks. landed in r35654

[Alp Toker]

Hi,

The patch was missing a $ and broke the build:

+                  libxslt >= LIBXSLT_REQUIRED_VERSION

Moreover, we do check for libxslt, but only if XSL support is enabled in configure:

# check if libxslt is available
if test "$enable_xslt" = "yes"; then
   PKG_CHECK_MODULES([LIBXSLT],[libxslt >= $LIBXSLT_REQUIRED_VERSION])
   AC_SUBST([LIBXSLT_CFLAGS])
   AC_SUBST([LIBXSLT_LIBS])
fi

Jan, was the existing XSLT check broken for you?

[Alp Toker]

(In reply to comment #3)
> Thanks. landed in r35654
> 

Backed out in r35655 to get things building. Jan, can you describe the configure issue so we can try again if there's still an issue?

Cheers

[Jan Alonzo]

Hi Alp

Thanks for the rollback. This issue doesn't seem to be a WebKit/Gtk issue, but rather a packaged webkitgtk issue. Closing as INVALID as we don't really have to do anything here.

FYI, I think you need to update the changelog which revision was actually rolled back. Here's your commit message:


    GTK+ build fixes.

    Back out r20338 libxslt check (conditional check already exists and
    this broke the build).

    Make the flex version check a warning rather than fatal to fix the
    build bot. 

Cheers