Summary: | REGRESSION: [ iOS ] ( r251015 ) Layout Test fast/text/whitespace/pre-wrap-overflow-selection.html is flaky | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Truitt Savell <tsavell> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, koivisto, rniwa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Truitt Savell
2019-10-24 08:45:57 PDT
*** Bug 203363 has been marked as a duplicate of this bug. *** marked this as a failure in https://trac.webkit.org/changeset/251538/webkit while it is investigated and to avoid slowing down iOS EWS. Created attachment 382844 [details]
patch
Created attachment 382941 [details]
patch that fixes the underlying flakiness
Comment on attachment 382941 [details] patch that fixes the underlying flakiness View in context: https://bugs.webkit.org/attachment.cgi?id=382941&action=review > Source/WebKit/ChangeLog:13 > + In this case the randomess is switch between simple and complex line layout triggered by editor state flush. The results "randomess is switch" > Source/WebKit/ChangeLog:14 > + between line layout paths are obsevably identical but produce slightly different render tree dumps. "obsevably" > Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:518 > + WebKit::toImpl(page)->flushPendingEditorStateUpdate(); Seems like this is something that we should to at "update the rendering" time? (In a later fix). Created attachment 382976 [details]
patch
Comment on attachment 382976 [details] patch Rejecting attachment 382976 [details] from commit-queue. New failing tests: webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html Full output: https://webkit-queues.webkit.org/results/13220879 Created attachment 383000 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6
The commit-queue encountered the following flaky tests while processing attachment 382976 [details]: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 382976 [details] patch Clearing flags on attachment: 382976 Committed r252172: <https://trac.webkit.org/changeset/252172> All reviewed patches have been landed. Closing bug. |