Bug 203351

Summary: [JSC] Remove wasmAwareLexicalGlobalObject
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, hi, joepeck, kangil.han, keith_miller, mark.lam, mkwst, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-10-23 18:49:28 PDT
[JSC] Remove wasmAwareLexicalGlobalObject
Attachments
Patch (25.88 KB, patch)
2019-10-23 18:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.85 KB, patch)
2019-10-23 18:51 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.86 KB, patch)
2019-10-23 19:09 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.92 KB, patch)
2019-10-23 20:15 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.95 KB, patch)
2019-10-23 20:25 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-10-23 18:50:11 PDT
Created attachment 381761 [details] Patch
Yusuke Suzuki
Comment 2 2019-10-23 18:51:06 PDT
Created attachment 381762 [details] Patch
Yusuke Suzuki
Comment 3 2019-10-23 19:09:49 PDT
Created attachment 381764 [details] Patch
Yusuke Suzuki
Comment 4 2019-10-23 20:15:11 PDT
Created attachment 381769 [details] Patch
Yusuke Suzuki
Comment 5 2019-10-23 20:25:14 PDT
Created attachment 381770 [details] Patch
Mark Lam
Comment 6 2019-10-23 21:56:05 PDT
Comment on attachment 381770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381770&action=review r=me with suggested improvement. > Source/JavaScriptCore/interpreter/CallFrame.cpp:356 > +JSGlobalObject* CallFrame::lexicalGlobalObjectFromWasmCallee(VM& vm) const > +{ > +#if ENABLE(WEBASSEMBLY) > + return vm.wasmContext.load()->owner<JSWebAssemblyInstance>()->globalObject(); > +#else > + UNUSED_PARAM(vm); > + return nullptr; > +#endif > +} Why not wrap the whole function in #if ENABLE(WEBASSEMBLY) and remove the #else case altogether? After all, this function can only be called if ENABLE(WEBASSEMBLY). > Source/JavaScriptCore/interpreter/CallFrame.h:170 > + JS_EXPORT_PRIVATE JSGlobalObject* lexicalGlobalObjectFromWasmCallee(VM&) const; Wrap in #if ENABLE(WEBASSEMBLY).
Yusuke Suzuki
Comment 7 2019-10-23 22:31:23 PDT
Comment on attachment 381770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381770&action=review Thanks >> Source/JavaScriptCore/interpreter/CallFrame.cpp:356 >> +} > > Why not wrap the whole function in #if ENABLE(WEBASSEMBLY) and remove the #else case altogether? After all, this function can only be called if ENABLE(WEBASSEMBLY). I don't have strong preference here. OK, I'll just wrap it.
Yusuke Suzuki
Comment 8 2019-10-23 22:34:27 PDT
Committed r251529: <https://trac.webkit.org/changeset/251529>
Radar WebKit Bug Importer
Comment 9 2019-10-23 22:35:12 PDT
<rdar://problem/56568321>
Note You need to log in before you can comment on or make changes to this bug.