Bug 203303

Summary: Speculative revalidation toggle in mini-browser has no effect
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: cdumez, youennf
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2019-10-23 11:09:06 PDT
Speculative revalidation toggle in mini-browser has no effect, it likely had some effect in the past.
Attachments
Patch (4.07 KB, patch)
2019-10-23 11:10 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2019-10-23 11:10:19 PDT
Created attachment 381698 [details] Patch
Rob Buis
Comment 2 2019-10-23 12:14:59 PDT
Comment on attachment 381698 [details] Patch There is probably more related code that can be removed, let me know if that is the case.
Rob Buis
Comment 3 2019-11-11 12:34:18 PST
I think this code has no effect? Of course if the intention is for it to have some effect, I am guessing the defaultConfiguration getter in MiniBrowser/mac/AppDelegate.m needs to take it into account.
youenn fablet
Comment 4 2019-12-03 07:50:29 PST
Comment on attachment 381698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381698&action=review > Tools/ChangeLog:9 > + remove it. Do you know why it is not working? I would guess we would want the toggle to work.
Rob Buis
Comment 5 2020-05-30 04:44:32 PDT
Not working on this.
Note You need to log in before you can comment on or make changes to this bug.