Summary: | WKWebView: WKURLSchemeHandler request don't have Range headers | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jcesarmobile <juliosincesar> | ||||||||||
Component: | Media | Assignee: | Alex Christensen <achristensen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Major | CC: | achristensen, beidson, felix741, ggaren, jean-baptiste.martin, jer.noble, kewlbear, lindsay-needs-sleep, mjs, thkim, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | iPhone / iPad | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
jcesarmobile
2019-10-23 10:30:02 PDT
WKURLSchemeHandler is behaving correctly here, and on Mac the same code has a range request. The problem is on iOS the request we receive from AVAssetResourceLoader does not have a range request, but on Mac the request we receive in the WebCoreNSURLSession has a range request. I'm uploading a test that verifies this is the case. Created attachment 381757 [details]
Patch
Comment on attachment 381757 [details]
Patch
r=me
Can you file a bug report for AVAssetResourceLoader?
Are you asking me or somebody else? In case it's me, where should I report the new issue? I think he was asking me to report another bug and use this just to commit the test that verifies existing behavior. I'm still talking to people and deciding what to do about this. We have faced the same no Range header problem using WKURLSchemeHandler for custom video scheme on iOS. Does it still remain an unresolved bug even after 6 months later from the first report? Nonetheless, is there any one who happens to know how to detour this bug so that we can manage to catch the Range data from AVAssetResourceLoader? It is so desperate to finalize our project. Hi, any new on this? Is there anywhere we can follow this issue(AVAssetResourceLoader or something else)? Hello, is there anything new in this Bug? The problem persists and makes it impossible to view larger files from local storage. Created attachment 427459 [details]
Patch
Comment on attachment 427459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427459&action=review r=me - plz fix test build > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:1514 > + @"Content-Range" : [NSString stringWithFormat:@"bytes %llu-%llu/%lu", rangeBegin, rangeEnd, [videoData length]], > + @"Content-Length" : [NSString stringWithFormat:@"%llu", rangeEnd - rangeBegin + 1] /Volumes/Data/worker/watchOS-7-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:1513:105: error: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Werror,-Wformat] Created attachment 427464 [details]
Patch
iOS test failures look related. Will investigate. It seems like blob URLs are going through this path too. I'm going to exclude the blob protocol. Created attachment 427587 [details]
Patch
|