Bug 203268

Summary: [JSC tests] Skip slow tests on Watch S3 and Watch S4
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: JavaScriptCoreAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbedard, keith_miller, mark.lam, saam, webkit-bug-importer, ysuzuki, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+, commit-queue: commit-queue-

Description Zhifei Fang 2019-10-22 13:57:14 PDT
[JSC tests] Skip slow tests on Watch S3 and Watch S4
Comment 1 Zhifei Fang 2019-10-22 14:00:31 PDT
Created attachment 381594 [details]
Patch
Comment 2 Zhifei Fang 2019-10-22 14:07:11 PDT
Created attachment 381596 [details]
Patch
Comment 3 WebKit Commit Bot 2019-10-22 15:20:23 PDT
Comment on attachment 381596 [details]
Patch

Rejecting attachment 381596 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 381596, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
ce.js
	M	JSTests/microbenchmarks/string-sub.js
	M	JSTests/microbenchmarks/string-test.js
	M	JSTests/microbenchmarks/string-transcoding.js
	M	JSTests/microbenchmarks/string-var-equality.js
	M	JSTests/microbenchmarks/stringalloc.js
	M	JSTests/microbenchmarks/structure-hoist-over-transitions.js
	M	JSTests/microbenchmarks/substring-concat-weird.js
	M	JSTests/microbenchmarks/substring-concat.js
	M	JSTests/microbenchmarks/substring.js
	M	JSTests/microbenchmarks/super-get-by-id-with-this-monomorphic.js
	M	JSTests/microbenchmarks/super-get-by-id-with-this-polymorphic.js
	M	JSTests/microbenchmarks/super-get-by-val-with-this-monomorphic.js
	M	JSTests/microbenchmarks/super-get-by-val-with-this-polymorphic.js
	M	JSTests/microbenchmarks/super-getter.js
	M	JSTests/microbenchmarks/switch-char-constant.js
	M	JSTests/microbenchmarks/switch-char.js
	M	JSTests/microbenchmarks/switch-constant.js
	M	JSTests/microbenchmarks/switch-string-basic-big-var.js
	M	JSTests/microbenchmarks/switch-string-basic-big.js
	M	JSTests/microbenchmarks/switch-string-basic-var.js
	M	JSTests/microbenchmarks/switch-string-basic.js
	M	JSTests/microbenchmarks/switch-string-big-length-tower-var.js
	M	JSTests/microbenchmarks/switch-string-length-tower-var.js
	M	JSTests/microbenchmarks/switch-string-length-tower.js
	M	JSTests/microbenchmarks/switch-string-short.js
	M	JSTests/microbenchmarks/switch.js
	M	JSTests/microbenchmarks/switching-size-classes.js
	M	JSTests/microbenchmarks/symbol-creation.js
	M	JSTests/microbenchmarks/symbol-tostringtag.js
	M	JSTests/microbenchmarks/tan.js
	M	JSTests/microbenchmarks/tear-off-arguments-simple.js
	M	JSTests/microbenchmarks/tear-off-arguments.js
	M	JSTests/microbenchmarks/template-string-array.js
	M	JSTests/microbenchmarks/temporal-structure.js
	M	JSTests/microbenchmarks/throw.js
	M	JSTests/microbenchmarks/to-int32-boolean.js
	M	JSTests/microbenchmarks/to-number-boolean.js
	M	JSTests/microbenchmarks/to-number-constructor-number-string-number-string.js
	M	JSTests/microbenchmarks/to-number-constructor-only-number.js
	M	JSTests/microbenchmarks/to-number-constructor-only-string.js
	M	JSTests/microbenchmarks/to-number-constructor-string-number-string-number.js
	M	JSTests/microbenchmarks/to-number-number-string-number-string.js
	M	JSTests/microbenchmarks/to-number-only-number.js
	M	JSTests/microbenchmarks/to-number-only-string.js
	M	JSTests/microbenchmarks/to-number-string-number-string-number.js
	M	JSTests/microbenchmarks/to-string-on-cow-array.js
	M	JSTests/microbenchmarks/try-catch-get-by-val-cloned-arguments.js
	M	JSTests/microbenchmarks/try-catch-get-by-val-direct-arguments.js
	M	JSTests/microbenchmarks/try-catch-get-by-val-scoped-arguments.js
	M	JSTests/microbenchmarks/try-catch-word-count.js
	M	JSTests/microbenchmarks/try-get-by-id-basic.js
	M	JSTests/microbenchmarks/try-get-by-id-polymorphic.js
	M	JSTests/microbenchmarks/typed-array-get-set-by-val-profiling.js
	M	JSTests/microbenchmarks/typed-array-subarray.js
	M	JSTests/microbenchmarks/typed-array-sum.js
	M	JSTests/microbenchmarks/undefined-test.js
	M	JSTests/microbenchmarks/unprofiled-licm.js
	M	JSTests/microbenchmarks/untyped-string-from-char-code.js
	M	JSTests/microbenchmarks/v8-raytrace-with-empty-try-catch.js
	M	JSTests/microbenchmarks/v8-raytrace-with-try-catch.js
	M	JSTests/microbenchmarks/v8-regexp-search.js
	M	JSTests/microbenchmarks/varargs-call.js
	M	JSTests/microbenchmarks/varargs-construct-inline.js
	M	JSTests/microbenchmarks/varargs-construct.js
	M	JSTests/microbenchmarks/varargs-inline.js
	M	JSTests/microbenchmarks/varargs-strict-mode.js
	M	JSTests/microbenchmarks/varargs.js
	M	JSTests/microbenchmarks/vector-length-hint-array-constructor.js
	M	JSTests/microbenchmarks/vector-length-hint-new-array.js
	M	JSTests/microbenchmarks/weak-map-key.js
	M	JSTests/microbenchmarks/weak-set-key.js
	M	JSTests/microbenchmarks/weird-inlining-const-prop.js

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/JSTests/microbenchmarks/delay-tear-off-arguments-strictmode.js
        trunk/JSTests/microbenchmarks/emscripten-cube2hash.js
        trunk/JSTests/microbenchmarks/polymorphic-array-call.js
        trunk/JSTests/microbenchmarks/sorting-benchmark.js

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
W: 746e4ac766eb71fe6af9b45793d94fbf7f09a848 and refs/remotes/origin/master differ, using rebase:
:040000 040000 ecd2fa1466141c803cce8d8941e19fe47a0a47a8 d5e43aefd614b40984bc4d54042f49506cfaafa6 M	JSTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/13164903
Comment 4 Zhifei Fang 2019-10-22 15:47:11 PDT
Committed r251463: <https://trac.webkit.org/changeset/251463>
Comment 5 Radar WebKit Bug Importer 2019-10-22 15:48:18 PDT
<rdar://problem/56519278>