Bug 203263

Summary: [ews] Download the build archive from master when download from S3 fails
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197949
https://bugs.webkit.org/show_bug.cgi?id=203246
https://bugs.webkit.org/show_bug.cgi?id=220932
Attachments:
Description Flags
Patch
none
Patch jbedard: review+

Aakash Jain
Reported 2019-10-22 12:47:23 PDT
[ews] Download the build archive from master when download from S3 fails. This would act as a fallback option when S3 is having problems (like it is having currently).
Attachments
Patch (6.65 KB, patch)
2019-10-22 12:55 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (6.60 KB, patch)
2019-10-22 13:23 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-10-22 12:55:30 PDT
Created attachment 381585 [details] Patch
Jonathan Bedard
Comment 2 2019-10-22 13:04:53 PDT
Comment on attachment 381585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381585&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1313 > + if rc == FAILURE: Should this be rc != SUCCESS? > Tools/BuildSlaveSupport/ews-build/steps.py:1321 > + WithProperties(EWS_URL + 'ews-archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')] This looks wrong. It would resolve to 'https://ews-build.webkit.org/ews-archives.webkit.org/....'
Aakash Jain
Comment 3 2019-10-22 13:23:33 PDT
Comment on attachment 381585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381585&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:1313 >> + if rc == FAILURE: > > Should this be rc != SUCCESS? This is fine, we don't want to add that step in case of WARNINGS, SKIPPED or EXCEPTION. We use similar logic at other places as well, e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L108 >> Tools/BuildSlaveSupport/ews-build/steps.py:1321 >> + WithProperties(EWS_URL + 'ews-archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')] > > This looks wrong. It would resolve to 'https://ews-build.webkit.org/ews-archives.webkit.org/....' And that's why we have code-reviews. Thanks for noticing. Fixed in updated patch.
Aakash Jain
Comment 4 2019-10-22 13:23:44 PDT
Created attachment 381587 [details] Patch
Aakash Jain
Comment 5 2019-10-22 13:27:03 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/4/builds/12
Aakash Jain
Comment 6 2019-10-22 13:40:09 PDT
Committed r251450: <https://trac.webkit.org/changeset/251450>
Radar WebKit Bug Importer
Comment 7 2019-10-22 13:41:18 PDT
<rdar://problem/56513673>
Aakash Jain
Comment 8 2019-10-22 17:08:16 PDT
Deployed in production few hours back. Example of situation where this change helped: https://ews-build.webkit.org/#/builders/14/builds/5251
Note You need to log in before you can comment on or make changes to this bug.