Bug 203238

Summary: [Web Animations] Only process CSS properties affected by a given CSS transition
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Antoine Quint
Reported 2019-10-22 01:17:18 PDT
[Web Animations] Only process CSS properties affected by a given CSS transition
Attachments
Patch (4.84 KB, patch)
2019-10-22 01:21 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (27.28 KB, patch)
2019-10-24 02:58 PDT, Antoine Quint 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-10-22 01:21:05 PDT
Created attachment 381524 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-10-22 01:21:58 PDT
<rdar://problem/56492517>
Simon Fraser (smfr)
Comment 3 2019-10-22 08:09:32 PDT
Comment on attachment 381524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381524&action=review > Source/WebCore/animation/AnimationTimeline.cpp:497 > + auto compileTransitionPropertiesInStyle = [&](const RenderStyle& style) { This is already a long function. I think you should move this and processProperty into real functions.
Antoine Quint
Comment 4 2019-10-24 02:58:56 PDT
Created attachment 381793 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-10-24 08:49:54 PDT
Comment on attachment 381793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381793&action=review > Source/WebCore/animation/AnimationTimeline.cpp:379 > +void AnimationTimeline::updateCSSTransitionsForElementAndProperty(Element& element, CSSPropertyID property, const RenderStyle& currentStyle, const RenderStyle& afterChangeStyle, AnimationTimeline::PropertyToTransitionMap& runningTransitionsByProperty, PropertyToTransitionMap& completedTransitionsByProperty, const MonotonicTime& generationTime) You can pass MonotonicTime by value (it has sizeof(double)). > Source/WebCore/animation/AnimationTimeline.cpp:535 > } I would return here and remove the else.
Antoine Quint
Comment 6 2019-10-24 09:35:16 PDT
Committed r251543: <https://trac.webkit.org/changeset/251543>
Note You need to log in before you can comment on or make changes to this bug.