Summary: | Fix incorrect assertion in operationRegExpExecNonGlobalOrSticky(). | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mark Lam
2019-10-21 18:19:15 PDT
Created attachment 381497 [details]
proposed patch.
Comment on attachment 381497 [details]
proposed patch.
r=me
Thanks for the review. Landed in r251411: <http://trac.webkit.org/r251411>. The fix is incorrect and regressing some JSC tests. Rolled out in r251418: <http://trac.webkit.org/r251418>. Created attachment 381512 [details]
proposed patch.
Comment on attachment 381512 [details] proposed patch. Attachment 381512 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13161246 New failing tests: fast/repaint/backgroundSizeRepaint.html Created attachment 381519 [details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 381512 [details] proposed patch. Attachment 381512 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/13161354 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl (In reply to Build Bot from comment #6) > New failing tests: > fast/repaint/backgroundSizeRepaint.html This is failing due to slight differences in rendered pixels. It cannot possibly be due to this patch. (In reply to Build Bot from comment #8) > New failing tests: > mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl This is the test flaking out again. It's not related to this patch. Comment on attachment 381512 [details]
proposed patch.
r=me
Comment on attachment 381512 [details]
proposed patch.
Thanks for the review.
Comment on attachment 381512 [details] proposed patch. Clearing flags on attachment: 381512 Committed r251447: <https://trac.webkit.org/changeset/251447> All reviewed patches have been landed. Closing bug. |