XHRs logged in the console do not have line numbers

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Kevin McCullough]

8/5/08 11:04 AM Kevin McCullough:
* SUMMARY
In the console an XHR that is logged does not have line numbers so when clicking the URL of the resource that loaded it, the user is not taken to the line where the load occurred.  This is a feature that works in Firebug.

<rdar://problem/6126262 >

[Kevin McCullough]

Created attachment 23770 [details]
proposed patch

[Geoffrey Garen]

Comment on attachment 23770 [details]
proposed patch

This work seems harmless enough that it's OK to do even when the develop menu is disabled. Perhaps a Shark profile will tell us otherwise in the future.

[Timothy Hatcher]

You need to check the line number for -1, the error case. Otherwise storing it in the unsigned will give a huge number. The inspector expects 0 for unknown line numbers, not -1.

This is done in Console.cpp like:

    lineNumber = (signedLineNumber >= 0 ? signedLineNumber : 0);

[Kevin McCullough]

Committed revision 36894.