Bug 203201

Summary: [GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web InspectorAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cgarcia, commit-queue, ews-watchlist, gyuyoung.kim, inspector-bugzilla-changes, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Yury Semikhatsky
Reported 2019-10-21 12:40:09 PDT
This is possible on Mac but only works in Debug mode in GTK. Most of the Web Inspector UI is written in JavaScript so it's very convenient to be able to run release binary with original js source files. Disabling minification saves a lot of build time otherwise spent in jsmin.py when .js sources change.
Attachments
Patch (2.29 KB, patch)
2019-10-21 12:45 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.19 KB, patch)
2019-10-22 09:19 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2019-10-21 12:45:52 PDT
Created attachment 381430 [details] Patch
Carlos Garcia Campos
Comment 2 2019-10-22 01:33:18 PDT
Comment on attachment 381430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381430&action=review > Source/WebKit/InspectorGResources.cmake:52 > + elseif (DEVELOPER_MODE) > + set(COMBINE_INSPECTOR_RESOURCES YES) Now that inspector and test resources are split we don't need this branch. > Source/WebKit/InspectorGResources.cmake:61 > + if (CMAKE_BUILD_TYPE STREQUAL "Debug") > + set(COMBINE_TEST_RESOURCES YES) > + elseif (DEVELOPER_MODE) > + set(COMBINE_TEST_RESOURCES YES) And here we could use OR
Yury Semikhatsky
Comment 3 2019-10-22 09:12:41 PDT
Comment on attachment 381430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381430&action=review Thanks for quick review! >> Source/WebKit/InspectorGResources.cmake:52 >> + set(COMBINE_INSPECTOR_RESOURCES YES) > > Now that inspector and test resources are split we don't need this branch. Done. >> Source/WebKit/InspectorGResources.cmake:61 >> + set(COMBINE_TEST_RESOURCES YES) > > And here we could use OR Done.
Yury Semikhatsky
Comment 4 2019-10-22 09:19:28 PDT
Created attachment 381551 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-10-22 10:04:48 PDT
Comment on attachment 381551 [details] Patch for landing Clearing flags on attachment: 381551 Committed r251438: <https://trac.webkit.org/changeset/251438>
WebKit Commit Bot
Comment 6 2019-10-22 10:04:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-10-22 10:05:16 PDT
<rdar://problem/56504037>
Note You need to log in before you can comment on or make changes to this bug.