Bug 20318

Summary: [Gtk] SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
use G_PRIORITY_DEFAULT_IDLE for g_idle_add function
none
updated to use g_idle_add rather than the _full variant zecke: review+

Jan Alonzo
Reported 2008-08-07 07:34:43 PDT
In setSharedTimerFireTime: if (intervalInMS == 0) - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, NULL); + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, NULL, NULL); I'm attaching a patch for this.
Attachments
use G_PRIORITY_DEFAULT_IDLE for g_idle_add function (1.13 KB, patch)
2008-08-07 07:37 PDT, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
updated to use g_idle_add rather than the _full variant (1.10 KB, patch)
2008-08-08 17:50 PDT, Jan Alonzo 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2008-08-07 07:37:30 PDT
Created attachment 22697 [details] use G_PRIORITY_DEFAULT_IDLE for g_idle_add function
Alp Toker
Comment 2 2008-08-07 08:49:30 PDT
(In reply to comment #0) > In setSharedTimerFireTime: > > if (intervalInMS == 0) > - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, > NULL); > + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, > NULL, NULL); > > I'm attaching a patch for this. > Did this cause incorrect behaviour or is this patch just a cleanup? How about just using g_idle_add() (docs suggest it does the same thing)?
Jan Alonzo
Comment 3 2008-08-08 17:50:25 PDT
Created attachment 22715 [details] updated to use g_idle_add rather than the _full variant Hi Alp This is just a cleanup. I've updated the patch to use g_idle_add rather than g_idle_add_full.
Holger Freyther
Comment 4 2008-08-12 13:31:14 PDT
Comment on attachment 22715 [details] updated to use g_idle_add rather than the _full variant Please adjust the changelog when landing. According to the glib documentation g_idle_add is there from the beginning so we can safely use that.
Jan Alonzo
Comment 5 2008-08-13 12:43:16 PDT
landed in r35724
Note You need to log in before you can comment on or make changes to this bug.