Bug 203178

Summary: [iOS WK2] Support hiding iframe scrollbars via ::-webkit-scrollbar style
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, koivisto, kondapallykalyan, luiz, pdr, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206197
Bug Depends on: 203174    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Description Simon Fraser (smfr) 2019-10-18 18:31:44 PDT
[iOS WK2] Support hiding iframe scrollbars via ::-webkit-scrollbar style
Comment 1 Simon Fraser (smfr) 2019-10-18 18:34:51 PDT
Created attachment 381361 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-10-19 10:34:42 PDT
Created attachment 381373 [details]
Patch
Comment 3 Dean Jackson 2019-10-19 12:16:34 PDT
Comment on attachment 381373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381373&action=review

> LayoutTests/fast/scrolling/ios/scrollbar-hiding-iframes-expected.txt:17
> +    (total content size width=800 height=600)

Where does 800x600 come from?

> LayoutTests/fast/scrolling/ios/scrollbar-hiding-iframes-expected.txt:42
> +        (max layoutViewport origin (708,866))

Where does this number come from?
Comment 4 Simon Fraser (smfr) 2019-10-19 14:13:01 PDT
Comment on attachment 381373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381373&action=review

>> LayoutTests/fast/scrolling/ios/scrollbar-hiding-iframes-expected.txt:17
>> +    (total content size width=800 height=600)
> 
> Where does 800x600 come from?

Default WebKitTestRunner window size.

>> LayoutTests/fast/scrolling/ios/scrollbar-hiding-iframes-expected.txt:42
>> +        (max layoutViewport origin (708,866))
> 
> Where does this number come from?

Scrolling extent.
Comment 5 Simon Fraser (smfr) 2019-10-21 11:59:39 PDT
https://trac.webkit.org/changeset/251369/webkit
Comment 6 Radar WebKit Bug Importer 2019-10-21 12:00:21 PDT
<rdar://problem/56471145>