Bug 203176

Summary: [ Mac Debug WK1 ] REGRESSION (r251262?): fast/scrolling/latching/scroll-select-bottom-test.html is a Flaky Failure
Product: WebKit Reporter: Russell Epstein <repstein>
Component: Tools / TestsAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jlewis3, sihui_liu, simon.fraser, timothy, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202874
Attachments:
Description Flags
Patch
none
Patch
commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-03 for mac-highsierra
none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra
none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra none

Description Russell Epstein 2019-10-18 17:34:25 PDT
The following layout test has recently become flaky:

fast/scrolling/latching/scroll-select-bottom-test.html

Test History:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Flatching%2Fscroll-select-bottom-test.html

Diff:

--- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/scrolling/latching/scroll-select-bottom-test-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/scrolling/latching/scroll-select-bottom-test-actual.txt
@@ -12,5 +12,5 @@
 TEST COMPLETE
 div display height = 111
 Mouse moved to (30, 378)
-PASS Page did not receive wheel events.
+FAIL Page received wheel events.
Comment 1 Radar WebKit Bug Importer 2019-10-18 17:34:57 PDT
<rdar://problem/56425901>
Comment 2 Russell Epstein 2019-10-18 17:42:03 PDT
Marked Test as Flaky in r251314
Comment 3 Alexey Proskuryakov 2019-10-20 10:01:27 PDT
The suspected revision is very close to r251261, which caused other failures. Seems worth verifying with a local repro.
Comment 4 Matt Lewis 2019-10-23 16:39:11 PDT
(In reply to Alexey Proskuryakov from comment #3)
> The suspected revision is very close to r251261, which caused other
> failures. Seems worth verifying with a local repro.

We are actually rolling it out due to the associated bug, but this may not be the regression point.
Comment 5 Alexey Proskuryakov 2019-10-24 12:11:27 PDT
This test is still flaking after the rollback.
Comment 6 Simon Fraser (smfr) 2019-10-24 13:35:17 PDT
Seems like it's a rare flake on WK1 only.
Comment 7 Alexey Proskuryakov 2019-10-24 13:57:39 PDT
It still is the case tha this regressed a week ago.
Comment 8 Timothy Hatcher 2019-11-05 12:53:53 PST Comment hidden (obsolete)
Comment 9 Timothy Hatcher 2019-11-05 12:54:31 PST
This hasn't been flaky since r251565 when a related r251261 regression/bug was fixed. I was also able to run it locally against r252065 a total of 1,100 times with no failures. Patch posted to remove the flaky test expectation.
Comment 10 Timothy Hatcher 2019-11-05 19:09:12 PST
Created attachment 382883 [details]
Patch
Comment 11 WebKit Commit Bot 2019-11-05 20:23:02 PST Comment hidden (obsolete)
Comment 12 WebKit Commit Bot 2019-11-05 20:23:04 PST Comment hidden (obsolete)
Comment 13 WebKit Commit Bot 2019-11-06 07:54:08 PST Comment hidden (obsolete)
Comment 14 WebKit Commit Bot 2019-11-06 07:54:09 PST Comment hidden (obsolete)
Comment 15 WebKit Commit Bot 2019-11-06 10:58:28 PST Comment hidden (obsolete)
Comment 16 WebKit Commit Bot 2019-11-06 10:58:30 PST Comment hidden (obsolete)
Comment 17 Timothy Hatcher 2019-11-06 13:45:52 PST
https://trac.webkit.org/changeset/252146/webkit