Summary: | [Clang][Windows] Options.cpp(317,25): error: no matching function for call to 'optionTypeSpecificIndex' | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | JavaScriptCore | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2019-10-17 22:24:52 PDT
Created attachment 381277 [details]
Patch
Comment on attachment 381277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381277&action=review > Source/JavaScriptCore/ChangeLog:8 > + clang-cl reported a compilation error for MSVC bug workaournd code of optionTypeSpecificIndex. /workaournd/workaround/ > Source/JavaScriptCore/runtime/Options.cpp:294 > +#if COMPILER(CLANG) // for clang-cl Is both COMPILER(CLANG) and COMPILER(MSVC) true at the same time for MSVC with Clang backend? Note that this snippet of code is wrapped in a #if COMPILER(MSVC). Comment on attachment 381277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381277&action=review > Source/JavaScriptCore/runtime/Options.cpp:297 > size_t index; I wonder if we can just change this to "size_t index = 0;" and keep the "index = 0;" below as well. Would that appease both clang and the MSVC backend? Comment on attachment 381277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381277&action=review >> Source/JavaScriptCore/runtime/Options.cpp:294 >> +#if COMPILER(CLANG) // for clang-cl > > Is both COMPILER(CLANG) and COMPILER(MSVC) true at the same time for MSVC with Clang backend? Note that this snippet of code is wrapped in a #if COMPILER(MSVC). Yes. clang-cl compiles the almost same code path with MSVC. >> Source/JavaScriptCore/runtime/Options.cpp:297 >> size_t index; > > I wonder if we can just change this to "size_t index = 0;" and keep the "index = 0;" below as well. Would that appease both clang and the MSVC backend? Will try. Created attachment 381281 [details]
Patch
Committed r251276: <https://trac.webkit.org/changeset/251276> |