Summary: | [gtk] implements FrameLoaderClient::dispatchDidChangeLocationWithinPage | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | christian, cosimoc, jmalonzo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Bug Depends on: | 17066 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
arno.
2008-08-06 13:35:10 PDT
Created attachment 22705 [details]
first attempt patch
Created attachment 22706 [details]
second attempt
emit signal on frame, and on view only if we're in the main frame
Hi arno Is your patch for review? If so can you please change the flag to '?' so it will go to the review queue? Thanks for the patch! Comment on attachment 22706 [details] second attempt I was waiting for bug 17066, but may be we can still fix this one before Comment on attachment 22706 [details] second attempt Let me comment on the style first: > void FrameLoaderClient::dispatchDidChangeLocationWithinPage() > { > - notImplemented(); > + /* Update the URI > + */ // Update the URI or /* * Update the URI */ > + if (m_frame == webkit_web_view_get_main_frame(webView)) > + g_signal_emit_by_name(webView, "location-changed-within-page", m_frame); > } early exits (like found in many places): if (m_frame != webkit_web_get_main_frame(webView)) return; g_signal_emit_by_name(webView, "... Created attachment 25028 [details]
style update
Thanks for your comments. Here is an updated patch
Do we really need a separate signal signal for this? In bug 14807 I'm adding notifications for the URI and title properties, so it should be sufficient to monitor the URI. It is easily distiguishable since no loading or progress information would change. Comment on attachment 25028 [details]
style update
I agree with Christian in this matter - there is no need to create a new signal for this, let's just use the properties, and have them notified at dispatchDidChangeLocationWithinPage.
|