Bug 203043

Summary: Non-cocoa platforms don't pass networkCacheDirectory from WebsiteDataStore::parameters()
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: WebKit2Assignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alex, cgarcia, commit-queue, pnormand, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Emilio Cobos Álvarez (:emilio) 2019-10-16 10:46:25 PDT 
Which causes the test runner and minibrowser error non-fatally with various messages like:

ERROR: Failed to initialize the WebKit network disk cache
Comment 1 Emilio Cobos Álvarez (:emilio) 2019-10-16 10:50:45 PDT 
Created attachment 381085 [details]
Patch
Comment 2 Emilio Cobos Álvarez (:emilio) 2019-10-16 10:52:21 PDT 
Probably need to do a bit of archeology, but this should be enough for EWS.
Comment 3 Alex Christensen 2019-10-16 18:59:07 PDT 
We should probably unite the WebsiteDataStore::parameters functions.
Comment 4 WebKit Commit Bot 2019-10-16 19:42:36 PDT 
Comment on attachment 381085 [details]
Patch

Clearing flags on attachment: 381085

Committed r251222: <https://trac.webkit.org/changeset/251222>
Comment 5 WebKit Commit Bot 2019-10-16 19:42:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-16 19:43:15 PDT 
<rdar://problem/56356248>
Comment 7 Philippe Normand 2019-11-14 05:22:45 PST 
I suspect this might have caused bug #203460. Setting parameters.networkSessionParameters.networkCacheDirectory is not enough, I think you need to ensure the directory exists, like done for localStorageDirectory.
Comment 8 Philippe Normand 2019-11-14 10:23:17 PST 
(In reply to Philippe Normand from comment #7)
> I suspect this might have caused bug #203460. 

It's not the cause of that bug, but

> Setting
> parameters.networkSessionParameters.networkCacheDirectory is not enough, I
> think you need to ensure the directory exists, like done for
> localStorageDirectory.

It would be good to have this suggested change as a follow-up :)