Bug 203043

Summary: Non-cocoa platforms don't pass networkCacheDirectory from WebsiteDataStore::parameters()
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: WebKit2Assignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alex, cgarcia, commit-queue, pnormand, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emilio Cobos Álvarez (:emilio)
Reported 2019-10-16 10:46:25 PDT
Which causes the test runner and minibrowser error non-fatally with various messages like: ERROR: Failed to initialize the WebKit network disk cache
Attachments
Patch (1.53 KB, patch)
2019-10-16 10:50 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2019-10-16 10:50:45 PDT
Created attachment 381085 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 2 2019-10-16 10:52:21 PDT
Probably need to do a bit of archeology, but this should be enough for EWS.
Alex Christensen
Comment 3 2019-10-16 18:59:07 PDT
We should probably unite the WebsiteDataStore::parameters functions.
WebKit Commit Bot
Comment 4 2019-10-16 19:42:36 PDT
Comment on attachment 381085 [details] Patch Clearing flags on attachment: 381085 Committed r251222: <https://trac.webkit.org/changeset/251222>
WebKit Commit Bot
Comment 5 2019-10-16 19:42:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-16 19:43:15 PDT
<rdar://problem/56356248>
Philippe Normand
Comment 7 2019-11-14 05:22:45 PST
I suspect this might have caused bug #203460. Setting parameters.networkSessionParameters.networkCacheDirectory is not enough, I think you need to ensure the directory exists, like done for localStorageDirectory.
Philippe Normand
Comment 8 2019-11-14 10:23:17 PST
(In reply to Philippe Normand from comment #7) > I suspect this might have caused bug #203460. It's not the cause of that bug, but > Setting > parameters.networkSessionParameters.networkCacheDirectory is not enough, I > think you need to ensure the directory exists, like done for > localStorageDirectory. It would be good to have this suggested change as a follow-up :)
Note You need to log in before you can comment on or make changes to this bug.