Bug 203027

Summary: prepare-ChangeLog should whine about not having tests in WebKit-only patches
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, megan_gardner, mjs, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Tim Horton
Reported 2019-10-16 00:07:03 PDT
prepare-ChangeLog should whine about not having tests in WebKit
Attachments
Patch (2.36 KB, patch)
2019-10-16 00:08 PDT, Tim Horton 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-10-16 00:08:26 PDT
Created attachment 381059 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-10-16 11:34:00 PDT
What does "in WebKit" mean in the title?
Tim Horton
Comment 3 2019-10-16 11:40:41 PDT
(In reply to Simon Fraser (smfr) from comment #2) > What does "in WebKit" mean in the title? Source/WebKit. Right now if you make a WK2-only patch, you won't get shamed into having tests. Only if you touch WebCore.
Tim Horton
Comment 4 2019-10-16 11:41:33 PDT
(In reply to Tim Horton from comment #3) > (In reply to Simon Fraser (smfr) from comment #2) > > What does "in WebKit" mean in the title? > > Source/WebKit. > > Right now if you make a WK2-only patch, you won't get shamed into having > tests. Only if you touch WebCore. I think I might flip the "higher of" to "deeper of" (so that if you make a WebCore and WebKit change, the message is in WebCore, not WebKit). I started the other way around, but thinking more I think that's wrong.
Simon Fraser (smfr)
Comment 5 2019-10-16 12:52:33 PDT
Better title would be "prepare-ChangeLog should not whine about not having tests for code changes that are WebKit-only"
Tim Horton
Comment 6 2019-10-16 12:53:54 PDT
Well that would be backwards
Tim Horton
Comment 7 2019-10-16 12:54:11 PDT
How's that
Tim Horton
Comment 8 2019-10-23 00:31:48 PDT
I flipped it around so that if you have both a WebCore + WebKit change, it will only complain in WebCore instead of only in WebKit (which was what my original patch did). https://trac.webkit.org/changeset/251476/webkit
Radar WebKit Bug Importer
Comment 9 2019-10-23 00:32:16 PDT
<rdar://problem/56530897>
Note You need to log in before you can comment on or make changes to this bug.