Bug 202999

Summary: [ews] Use python 3 compatible way to represent octal in buildbot code
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, lingcherd_ho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-10-15 12:04:43 PDT
Both Python 2 and 3 supports octal numbers in the format 0o022. Although 0o format is mandatory in Python 3, as https://docs.python.org/3.0/whatsnew/3.0.html#integers specifies: "Octal literals are no longer of the form 0720; use 0o720 instead." We should change the octal numbers to 0o format, as this is supported by both python 2 and 3, and is a small step towards making the code python 3 compatible.
Attachments
Patch (2.16 KB, patch)
2019-10-15 12:05 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-10-15 12:05:59 PDT
Created attachment 381009 [details] Patch
WebKit Commit Bot
Comment 2 2019-10-15 13:29:38 PDT
Comment on attachment 381009 [details] Patch Clearing flags on attachment: 381009 Committed r251153: <https://trac.webkit.org/changeset/251153>
WebKit Commit Bot
Comment 3 2019-10-15 13:29:39 PDT
All reviewed patches have been landed. Closing bug.
Ling Ho
Comment 4 2019-10-15 15:27:46 PDT
<rdar://problem/56305710>
Note You need to log in before you can comment on or make changes to this bug.