Summary: | Add some PencilKit extension points | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, jlewis3, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Daniel Bates
2019-10-14 16:34:16 PDT
This is the WebKit part corresponding to <rdar://problem/56261392>. Created attachment 380933 [details]
Patch
Comment on attachment 380933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380933&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:153 > +#if HAVE(PENCILKIT_ADDITIONS) Actually, maybe it would be better to check for the header itself to avoid breaking builds internally at least temporarily. Then change it back after the dust settles. (In reply to Daniel Bates from comment #4) > Comment on attachment 380933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380933&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:153 > > +#if HAVE(PENCILKIT_ADDITIONS) > > Actually, maybe it would be better to check for the header itself to avoid > breaking builds internally at least temporarily. Then change it back after > the dust settles. No need to do this. Everything will work outâ„¢ since HAVE_PENCILKIT_ADDITIONS is a new guard. Comment on attachment 380933 [details] Patch Clearing flags on attachment: 380933 Committed r251381: <https://trac.webkit.org/changeset/251381> All reviewed patches have been landed. Closing bug. Reverted r251381 for reason: This broke an internal build. Committed r251415: <https://trac.webkit.org/changeset/251415> Committed r251419: <https://trac.webkit.org/changeset/251419> |