Bug 202962

Summary: Add some PencilKit extension points
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, jlewis3, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2019-10-14 16:34:16 PDT
Add some PencilKit extension points.
Attachments
Patch (2.25 KB, patch)
2019-10-14 16:37 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-10-14 16:34:31 PDT
This is the WebKit part corresponding to <rdar://problem/56261392>.
Radar WebKit Bug Importer
Comment 2 2019-10-14 16:34:51 PDT
<rdar://problem/56269759>
Daniel Bates
Comment 3 2019-10-14 16:37:49 PDT
Created attachment 380933 [details] Patch
Daniel Bates
Comment 4 2019-10-14 17:09:43 PDT
Comment on attachment 380933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380933&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:153 > +#if HAVE(PENCILKIT_ADDITIONS) Actually, maybe it would be better to check for the header itself to avoid breaking builds internally at least temporarily. Then change it back after the dust settles.
Daniel Bates
Comment 5 2019-10-21 14:06:15 PDT
(In reply to Daniel Bates from comment #4) > Comment on attachment 380933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380933&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:153 > > +#if HAVE(PENCILKIT_ADDITIONS) > > Actually, maybe it would be better to check for the header itself to avoid > breaking builds internally at least temporarily. Then change it back after > the dust settles. No need to do this. Everything will work out™ since HAVE_PENCILKIT_ADDITIONS is a new guard.
Daniel Bates
Comment 6 2019-10-21 14:07:44 PDT
Comment on attachment 380933 [details] Patch Clearing flags on attachment: 380933 Committed r251381: <https://trac.webkit.org/changeset/251381>
Daniel Bates
Comment 7 2019-10-21 14:07:45 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 8 2019-10-21 21:46:05 PDT
Reverted r251381 for reason: This broke an internal build. Committed r251415: <https://trac.webkit.org/changeset/251415>
Daniel Bates
Comment 9 2019-10-21 23:05:48 PDT
Committed r251419: <https://trac.webkit.org/changeset/251419>
Note You need to log in before you can comment on or make changes to this bug.