Bug 202895

Summary: Fix compilation of Crypto.cpp on macOS with !WEB_CRYPTO
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebCore Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jiewen_tan, lingcherd_ho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2019-10-13 09:15:33 PDT
Crypto.cpp does not use getCommonCryptoDigestAlgorithm(), defined in CommonCryptoUtilities.h, but requires CommonCrypto includes which are coming with it. However, when WEB_CRYPTO is disabled necessary transitive includes are missing.
Attachments
Patch (1.34 KB, patch)
2019-10-13 09:17 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2019-10-13 09:17:04 PDT
Created attachment 380847 [details] Patch
Konstantin Tokarev
Comment 2 2019-10-13 12:25:50 PDT
Comment on attachment 380847 [details] Patch Clearing flags on attachment: 380847 Committed r251061: <https://trac.webkit.org/changeset/251061>
Konstantin Tokarev
Comment 3 2019-10-13 12:25:54 PDT
All reviewed patches have been landed. Closing bug.
Ling Ho
Comment 4 2019-10-15 15:10:50 PDT
<rdar://problem/56232550>
Note You need to log in before you can comment on or make changes to this bug.