Bug 202839 – [WinCairo] auto-installing raises exception "Inner message: global name 'urllib2' is not defined" since r250869

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

[WinCairo] auto-installing raises exception "Inner message: global name 'urllib2' is not defined" since r250869

auto-installing is failing since r250869 (Bug 201955) in fresh checkout WinCairo env (no autoinstalled modules).

PS C:\webkit\ga> python .\Tools\Scripts\check-webkit-style
Traceback (most recent call last):
  File ".\Tools\Scripts\check-webkit-style", line 44, in <module>
    from webkitpy.style.main import CheckWebKitStyle
  File "C:\webkit\ga\Tools\Scripts\webkitpy\style\main.py", line 27, in <module>
    import webkitpy.style.checker as checker
  File "C:\webkit\ga\Tools\Scripts\webkitpy\style\checker.py", line 53, in <module>
    from checkers.python import PythonChecker, Python3Checker
  File "C:\webkit\ga\Tools\Scripts\webkitpy\style\checkers\python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled import pep8
  File "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\__init__.py", line 98, in find_module
    self._install_pep8()
  File "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\__init__.py", line 148, in _install_pep8
    "pep8-0.5.0/pep8.py")
  File "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\__init__.py", line 294, in _install
    installer.install(url=url, url_subpath=url_subpath, target_name=target_name)
  File "C:\webkit\ga\Tools\Scripts\webkitpy\common\system\autoinstall.py", line 540, in install
    raise Exception(message)
Exception: Error auto-installing the pep8.py package to:
 "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\autoinstalled\pep8.py"
 --> Inner message: global name 'urllib2' is not defined


PS C:\webkit\ga> python ./Tools/Scripts/run-webkit-tests --wincairo --debug
Traceback (most recent call last):
  File "C:\webkit\ga\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 40, in <module>
    from webkitpy.layout_tests.controllers.manager import Manager
  File "C:\webkit\ga\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 59, in <module>
    from webkitpy.results.upload import Upload
  File "C:\webkit\ga\Tools\Scripts\webkitpy\results\upload.py", line 23, in <module>
    import webkitpy.thirdparty.autoinstalled.requests
  File "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\__init__.py", line 126, in find_module
    self._install_requests()
  File "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\__init__.py", line 189, in _install_requests
    "certifi-2019.3.9/certifi")
  File "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\__init__.py", line 294, in _install
    installer.install(url=url, url_subpath=url_subpath, target_name=target_name)
  File "C:\webkit\ga\Tools\Scripts\webkitpy\common\system\autoinstall.py", line 540, in install
    raise Exception(message)
Exception: Error auto-installing the certifi package to:
 "C:\webkit\ga\Tools\Scripts\webkitpy\thirdparty\autoinstalled\certifi"
 --> Inner message: global name 'urllib2' is not defined
PS C:\webkit\ga>

[Fujii Hironori]

Created attachment 380718 [details]
Patch

[Fujii Hironori]

Comment on attachment 380718 [details]
Patch

Clearing flags on attachment: 380718

Committed r251001: <https://trac.webkit.org/changeset/251001>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56180981>