Bug 202831

Summary: [cmake] Use HINTS instead of PATHS when searching in paths from pkg-config
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: CMakeAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cgarcia, commit-queue, ews-watchlist, gyuyoung.kim, mcatanzaro, rakuco, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2019-10-10 17:08:42 PDT
HINTS and PATHS sections are similar, however HINTS is processed before default system locations, while PATHS - after. If target file can be found in the system, pkg-config results are ignored in case of PATHS, making it impossible to override system version of library with PKG_CONFIG_PATH. Note that CMake documentation recommends using PATHS for hard-coded guesses.
Attachments
Patch (4.84 KB, patch)
2019-10-10 17:21 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2019-10-10 17:21:22 PDT
Created attachment 380705 [details] Patch
WebKit Commit Bot
Comment 2 2019-10-11 02:04:19 PDT
Comment on attachment 380705 [details] Patch Clearing flags on attachment: 380705 Committed r251005: <https://trac.webkit.org/changeset/251005>
WebKit Commit Bot
Comment 3 2019-10-11 02:04:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.