Summary: | [GTK][WPE] Several appcache and cache-storage tests are failing or flaky | ||
---|---|---|---|
Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | achristensen, bugs-noreply, clopez, dpino |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Miguel Gomez
2019-10-09 02:19:23 PDT
We have more tests failing due to r249614: http/tests/IndexedDB/storage-limit-2.https.html [ Failure ] http/tests/IndexedDB/storage-limit.https.html [ Failure ] storage/indexeddb/storage-limit.html [ Failure ] storage/indexeddb/modern/handle-user-delete.html [ Timeout ] storage/indexeddb/modern/new-database-after-user-delete.html [ Timeout ] and these are the diffs for the non timeout cases: http/tests/IndexedDB/storage-limit-2.https.html [ Failure ] --- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/IndexedDB/storage-limit-2.https-expected.txt +++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/IndexedDB/storage-limit-2.https-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: Cache API operation failed: Quota exceeded This test makes sure that storage of indexedDB and Cache API do not grow unboundedly. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". @@ -14,8 +13,9 @@ store = db.transaction('store', 'readwrite').objectStore('store') request = store.add(new Uint8Array(204800), 'key') finished idb processing -Cache API store operation failed: QuotaExceededError: Quota exceeded +FAIL Cache API store operation succeeded PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/IndexedDB/storage-limit.https.html [ Failure ] --- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/IndexedDB/storage-limit.https-expected.txt +++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/IndexedDB/storage-limit.https-actual.txt @@ -12,10 +12,9 @@ db = event.target.result store = db.transaction('store', 'readwrite').objectStore('store') request = store.add(new Uint8Array(204800), 'key') -PASS 'error' in request is true -PASS request.error.code is DOMException.QUOTA_EXCEEDED_ERR -PASS request.error.name is "QuotaExceededError" +FAIL Add operation should fail because storage limit is reached, but succeeded. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE storage/indexeddb/storage-limit.html [ Failure ] --- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/storage/indexeddb/storage-limit-expected.txt +++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/storage/indexeddb/storage-limit-actual.txt @@ -27,11 +27,9 @@ store.add(new Uint8Array(1), 9).onsuccess = ()=> { ++addCount; } store.add(new Uint8Array(1), 10).onsuccess = ()=> { ++addCount; } request = store.add(new Uint8Array(409601), 0) -PASS addCount is 10 -PASS 'error' in request is true -PASS request.error.code is DOMException.QUOTA_EXCEEDED_ERR -PASS request.error.name is "QuotaExceededError" +FAIL Add operation should fail because storage limit is reached, but succeeded. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE Are they only flaky on GTK? I looked on https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html and found most of them show no flakiness. When I've looked into similar issues, it was found that running a test after a certain other test (usually one that calls terminateNetworkProcess) caused the failures to be deterministic. I think the solution will be to migrate from anything that uses WebProcessPool::websiteDataStore, deprecating API along the way. There two tests are failing in GTK: * http/tests/appcache/remove-cache.html [ Failure Timeout Pass ] * http/wpt/cache-storage/quota-third-party.https.html [ Failure Timeout Pass] The tests started to consistently time out at: r249529 NOERROR [r249530-r249619] UNKNOWN r249620 TIMEOUT TEXT (Expected: PASS) Likely due to r249614 as well. *** Bug 206222 has been marked as a duplicate of this bug. *** A few tests are passing since r259705: storage/indexeddb/modern/handle-user-delete.html storage/indexeddb/modern/new-database-after-user-delete.html Updated test expectations in r260563. Many of these tests have been consistently passing since r259705. Updated test expectations in r261272. New expectations look like this (both for GTK and WPE): webkit.org/b/202736 http/tests/appcache/remove-cache.html [ Failure ] webkit.org/b/202736 http/wpt/cache-storage/quota-third-party.https.html [ Slow ] http/wpt/cache-storage/quota-third-party.https.html is flaky and gives timeouts. On the last 4000 runs on the gtk-release test bot it timed out 1022 times. Setting slow to it is not enough as it continues to give timeouts. |