Bug 20273 – Allow incrementing/decrementing numbers in editable style properties with arrow keys

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Timothy Hatcher]

Firebug lets you increment/decrement numbers at the insertion point with the arrow keys. We should support this.

[Timothy Hatcher]

Created attachment 22637 [details]
Patch 1 of 2

[Timothy Hatcher]

Created attachment 22638 [details]
Patch 2 of 2

[Adam Roben (:aroben)]

Comment on attachment 22637 [details]
Patch 1 of 2

I wonder if there's any way to reduce the code duplication in rangeOfWord?

r=me

[Adam Roben (:aroben)]

Comment on attachment 22638 [details]
Patch 2 of 2

+        var wordRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset , " \t\n\"':;,/()", this.listItemElement);

I think it would really improve readability to start putting these character sets into named variables, like cssValueDelimeters or something.

+            var changeAmount = (event.shiftKey ? 10 : ((event.altKey || numberNearZero) ? 0.1 : 1));

I think this would be a little clearer as if/elseif/else.

+        if ((shorthandProperty || individualProperty) in foundProperties)

I think you should put "(shorthandProperty || individualProperty) into a local variable since you keep repeating that construct.

Do you have any test cases to land with this?

r=me

[Anthony Ricaud]

Firebug uses Page up and down to increase/decrease by ten (see http://getfirebug.com/keyboard.html). I'm not a huge fan of that shortcut but I'm mentioning this for compatibility between tools.

[Timothy Hatcher]

Landed in r35560 and r35561.