Summary: | [CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149443 | ||||||
Attachments: |
|
Description
Antti Koivisto
2019-10-08 23:38:36 PDT
Created attachment 380502 [details]
patch
Comment on attachment 380502 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380502&action=review > Source/WebCore/css/SelectorChecker.cpp:1181 > + for (unsigned i = 0; i < element.partNames().size(); ++i) We can’t use range loop? > Source/WebCore/dom/ShadowRoot.h:99 > + using PartMappings = HashMap<AtomString, Vector<AtomString, 1>>; Should we typedef Vector? > We can’t use range loop? Not at the moment, SpaceSplitString doesn't have iterator interface. > Should we typedef Vector? Seems like overkill. Aliases make the code more opaque so I prefer only using them when types get pretty complicated. Comment on attachment 380502 [details] patch Clearing flags on attachment: 380502 Committed r250902: <https://trac.webkit.org/changeset/250902> All reviewed patches have been landed. Closing bug. |