Bug 202719

Summary: [CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149443    
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2019-10-08 23:38:36 PDT
exportparts="part:export1, part:export2" should work.
Attachments
patch (6.69 KB, patch)
2019-10-08 23:45 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-10-08 23:45:10 PDT
Created attachment 380502 [details] patch
Ryosuke Niwa
Comment 2 2019-10-09 00:28:01 PDT
Comment on attachment 380502 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380502&action=review > Source/WebCore/css/SelectorChecker.cpp:1181 > + for (unsigned i = 0; i < element.partNames().size(); ++i) We can’t use range loop? > Source/WebCore/dom/ShadowRoot.h:99 > + using PartMappings = HashMap<AtomString, Vector<AtomString, 1>>; Should we typedef Vector?
Antti Koivisto
Comment 3 2019-10-09 00:38:07 PDT
> We can’t use range loop? Not at the moment, SpaceSplitString doesn't have iterator interface. > Should we typedef Vector? Seems like overkill. Aliases make the code more opaque so I prefer only using them when types get pretty complicated.
WebKit Commit Bot
Comment 4 2019-10-09 01:25:41 PDT
Comment on attachment 380502 [details] patch Clearing flags on attachment: 380502 Committed r250902: <https://trac.webkit.org/changeset/250902>
WebKit Commit Bot
Comment 5 2019-10-09 01:25:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-09 01:26:18 PDT
<rdar://problem/56108565>
Note You need to log in before you can comment on or make changes to this bug.