Bug 20271 – Patches for NetBSD platform support

• Component: JavaScriptCore
• Status: RESOLVED INVALID

[Adam Hoka]

Attached are the patches we use in the work in progress NetBSD webkit-gtk package.
One adds the platform NETBSD and the other uses it to enable thread_attr_get_np.

[Adam Hoka]

Created attachment 22630 [details]
thread_attr_get_np is in libpthread on NetBSD

[Adam Hoka]

Created attachment 22631 [details]
Add the platform "NETBSD".

[Eric Seidel (no email)]

Comment on attachment 22630 [details]
thread_attr_get_np is in libpthread on NetBSD

Does NetBSD not have pthread_np.h?

[Eric Seidel (no email)]

ah, according to:
http://mail.kde.org/pipermail/kde-buildsystem/2006-March/001906.html

There is problem in kjs/collector.cpp file. At the moment it is assumed 
that if pthread_np.h exists (HAVE_PTHREAD_NP_H), pthread_attr_get_np() 
must be used. In NetBSD pthread_attr_get_np() must be used as well, but 
it is declared in pthread.h. Actual functions must be checked.

Ok, this is fine then.

[Eric Seidel (no email)]

Comment on attachment 22631 [details]
Add the platform "NETBSD".

OK.

[Eric Seidel (no email)]

Comment on attachment 22630 [details]
thread_attr_get_np is in libpthread on NetBSD

Please add a comment to explain that pthread_attr_get_np is present in NetBSD, but under pthread.h instead of pthread_np.h

Why oh why doesn't NetBSD add a pthread_np.h which just loads pthread.h...

This also needs a ChangeLog.

[Eric Seidel (no email)]

Comment on attachment 22631 [details]
Add the platform "NETBSD".

Oh, and yes, this needs a ChangeLog too.

[Mark Rowe (bdash)]

Perhaps we should introduce a HAVE(PTHREAD_ATTR_GET_NP) define which is set in Platform.h or config.h (I forget where we set such things) rather than cluttering up the collector code with a more complex condition?

[Adam Hoka]

(In reply to comment #4)
> ah, according to:
> http://mail.kde.org/pipermail/kde-buildsystem/2006-March/001906.html
> 
> There is problem in kjs/collector.cpp file. At the moment it is assumed 
> that if pthread_np.h exists (HAVE_PTHREAD_NP_H), pthread_attr_get_np() 
> must be used. In NetBSD pthread_attr_get_np() must be used as well, but 
> it is declared in pthread.h. Actual functions must be checked.
> 
> Ok, this is fine then.
> 

This is correct.

[Shawn Novak]

Created attachment 22691 [details]
Updated Patch against SVN r35619 with Changelog

This is an updated patch with Changelog being posted as requested on behalf of Adam Hoka.

[Kent Tamura]

(In reply to comment #10)
> Created an attachment (id=22691) [details]
> Updated Patch against SVN r35619 with Changelog
> 
> This is an updated patch with Changelog being posted as requested on behalf of Adam Hoka.

Do you want this patch reviewed? If so, please set review? flag.

[Gavin Barraclough]

Looks like this patch is now redundant, support for netbsd is already present in Platform.h.  Closing on the assumption that these changes are no longer necessary, please reopen if I'm mistaken.