Bug 202682

Summary: Web Inspector: Canvas: unable to click on overview path component when jumping directly to a shader
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, jonlee, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2019-10-07 21:47:07 PDT
# STEPS TO REPRODUCE:
1. inspect any page with a canvas that has any WebGL/WebGPU shaders (e.g. <https://webkit.org/demos/webgpu/compute-boids.html>)
2. go to the Canvas Tab
3. select any shader via the [gl] icon in the bottom left corner of one of the canvas preview tiles
4. try to click the "Overview" hierarchical path component to jump back to the overview
 => FAIL: nothing happens
5. select the parent Canvas/Device hierarchical path component
 => PASS: content changes
6. try to click the "Overview" hierarchical path component to jump back to the overview
 => PASS: content changes

A similar issue also happens if you initially click the canvas preview tile itself (replace step #3), select a shader in the navigation sidebar, and then try to click the Canvas/Device hierarchical path component.
Comment 1 Devin Rousso 2019-10-07 22:43:16 PDT
Created attachment 380403 [details]
Patch
Comment 2 Matt Baker 2019-10-08 11:52:18 PDT
I noticed the problem doesn't occur when navigating to the shader by clicking the canvas preview tile, instead of the [gl] icon context menu.
Comment 3 Matt Baker 2019-10-08 11:56:03 PDT
Comment on attachment 380403 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-10-08 13:15:23 PDT
Comment on attachment 380403 [details]
Patch

Clearing flags on attachment: 380403

Committed r250855: <https://trac.webkit.org/changeset/250855>
Comment 5 WebKit Commit Bot 2019-10-08 13:15:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-08 13:16:43 PDT
<rdar://problem/56085807>