Bug 202663

Summary: Rename force-press-related functions to refer to context menus, and fix a former force-press test
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Followup tweak none

Megan Gardner
Reported 2019-10-07 17:53:26 PDT
Remove iOS Force Press based tests
Attachments
Patch (10.06 KB, patch)
2019-10-07 17:55 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (10.66 KB, patch)
2019-10-07 18:01 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (26.57 KB, patch)
2019-10-22 18:09 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.75 KB, patch)
2019-10-23 16:39 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Followup tweak (1.50 KB, patch)
2019-10-25 15:08 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-10-07 17:55:25 PDT
Created attachment 380379 [details] Patch
Megan Gardner
Comment 2 2019-10-07 17:55:41 PDT
<rdar://problem/52699530>
Megan Gardner
Comment 3 2019-10-07 18:01:12 PDT
Created attachment 380380 [details] Patch
Megan Gardner
Comment 4 2019-10-22 18:09:49 PDT
Created attachment 381639 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-10-22 18:29:44 PDT
Comment on attachment 381639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381639&action=review > Source/WebKit/ChangeLog:10 > + relevant fuctions to more correclty reflect that this does not specifically correclty > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:483 > -- (void)_didShowForcePressPreview WK_API_AVAILABLE(ios(10.3)); > -- (void)_didDismissForcePressPreview WK_API_AVAILABLE(ios(10.3)); > +- (void)_didShowContextMenu WK_API_AVAILABLE(ios(10.3)); > +- (void)_didDismissContextMenu WK_API_AVAILABLE(ios(10.3)); Do any external clients use these? > LayoutTests/fast/events/touch/ios/long-press-on-link.html:22 > + let pressPointX = targetRect.x+targetRect.width / 2; > + let pressPointY = targetRect.y+targetRect.height / 2; Spaces around + please
Megan Gardner
Comment 6 2019-10-23 16:39:22 PDT
Created attachment 381752 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-10-23 19:22:53 PDT
Comment on attachment 381752 [details] Patch for landing Clearing flags on attachment: 381752 Committed r251522: <https://trac.webkit.org/changeset/251522>
WebKit Commit Bot
Comment 8 2019-10-23 19:22:55 PDT
All reviewed patches have been landed. Closing bug.
Wenson Hsieh
Comment 9 2019-10-25 15:08:50 PDT
Reopening to attach new patch.
Wenson Hsieh
Comment 10 2019-10-25 15:08:50 PDT
Created attachment 381970 [details] Followup tweak
WebKit Commit Bot
Comment 11 2019-10-25 18:40:33 PDT
Comment on attachment 381970 [details] Followup tweak Clearing flags on attachment: 381970 Committed r251622: <https://trac.webkit.org/changeset/251622>
WebKit Commit Bot
Comment 12 2019-10-25 18:40:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.