Summary: | [JSC] GetterSetter should be JSCell, not JSObject | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2019-10-07 15:38:27 PDT
Created attachment 380367 [details]
WIP
Created attachment 380461 [details]
Patch
Comment on attachment 380461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380461&action=review > Source/JavaScriptCore/ChangeLog:13 > + 2. RHS of that comparison is always folded into constant in DFG. do we do the right thing even when RHS isn't folded? > Source/JavaScriptCore/ChangeLog:17 > + So we already support non-JSString/JSBigInt cell comparison in JSC JS code. We should use it instead of making GetterSetter JSObject. this support was added after we made GetterSetter a JSObject? (In reply to Saam Barati from comment #4) > Comment on attachment 380461 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380461&action=review > > > Source/JavaScriptCore/ChangeLog:13 > > + 2. RHS of that comparison is always folded into constant in DFG. > > do we do the right thing even when RHS isn't folded? > > > Source/JavaScriptCore/ChangeLog:17 > > + So we already support non-JSString/JSBigInt cell comparison in JSC JS code. We should use it instead of making GetterSetter JSObject. > > this support was added after we made GetterSetter a JSObject? Sorry, I did not mean to clear Tadeu's r+ Comment on attachment 380461 [details]
Patch
r=me, r=Tadeu
Comment on attachment 380461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380461&action=review >>> Source/JavaScriptCore/ChangeLog:13 >>> + 2. RHS of that comparison is always folded into constant in DFG. >> >> do we do the right thing even when RHS isn't folded? > > Sorry, I did not mean to clear Tadeu's r+ Yes, existing code is doing the right thing. >> Source/JavaScriptCore/ChangeLog:17 >> + So we already support non-JSString/JSBigInt cell comparison in JSC JS code. We should use it instead of making GetterSetter JSObject. > > this support was added after we made GetterSetter a JSObject? Yes, it is added for Map#forEach. Committed r250878: <https://trac.webkit.org/changeset/250878> Committed r250932: <https://trac.webkit.org/changeset/250932> Committed r251088: <https://trac.webkit.org/changeset/251088> |