Summary: | Web Inspector: inspector/layers/layers-for-node.html and inspector/timeline/line-column.html are flaky | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||
Component: | Web Inspector | Assignee: | Yury Semikhatsky <yurys> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=137131 https://bugs.webkit.org/show_bug.cgi?id=203171 |
||||||||
Attachments: |
|
Description
Yury Semikhatsky
2019-10-07 13:10:49 PDT
Created attachment 380350 [details]
Patch
Comment on attachment 380350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380350&action=review rs=me > LayoutTests/inspector/layers/layers-for-node.html:25 > + layersChanged = InspectorProtocol.awaitEvent({event: "LayerTree.layerTreeDidChange"}) Frankly, given that `enableLayerTreeAgent` is called synchronously at the start of the test, perhaps we should just inline this at the top of `test` as a sort of "make sure we get at least one of these before continuing with the rest of the test". > LayoutTests/inspector/layers/layers-for-node.html:36 > + layersChanged.then(() => step({ Style: if the body of the arrow function is more than one line (or the value isn't intended as the return value), we add the `{ ... }` to the arrow function. ```js layersChanged.then(() => { step({ ... }); }); ``` Created attachment 380361 [details]
Patch
Comment on attachment 380350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380350&action=review >> LayoutTests/inspector/layers/layers-for-node.html:25 >> + layersChanged = InspectorProtocol.awaitEvent({event: "LayerTree.layerTreeDidChange"}) > > Frankly, given that `enableLayerTreeAgent` is called synchronously at the start of the test, perhaps we should just inline this at the top of `test` as a sort of "make sure we get at least one of these before continuing with the rest of the test". Done. >> LayoutTests/inspector/layers/layers-for-node.html:36 >> + layersChanged.then(() => step({ > > Style: if the body of the arrow function is more than one line (or the value isn't intended as the return value), we add the `{ ... }` to the arrow function. > ```js > layersChanged.then(() => { > step({ > ... > }); > }); > ``` Moved this logic out of the method. Comment on attachment 380361 [details]
Patch
rs=me
Comment on attachment 380361 [details] Patch Clearing flags on attachment: 380361 Committed r250872: <https://trac.webkit.org/changeset/250872> All reviewed patches have been landed. Closing bug. |