Bug 202647

Summary: [Clipboard API] Refactor Pasteboard item reading functions to work on both iOS and macOS
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP: Try to fix GTK/WPE builds
none
Patch
none
WIP: Try to fix WPE build
none
WIP: Try to fix WPE build again
none
WIP: Try to fix WPE build again
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2019-10-07 12:29:15 PDT
These functions are currently only defined on iOS.
Attachments
WIP (61.93 KB, patch)
2019-10-08 15:29 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
WIP: Try to fix GTK/WPE builds (63.51 KB, patch)
2019-10-08 16:10 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (68.91 KB, patch)
2019-10-08 16:50 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
WIP: Try to fix WPE build (68.70 KB, patch)
2019-10-08 17:03 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
WIP: Try to fix WPE build again (68.94 KB, patch)
2019-10-08 17:37 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
WIP: Try to fix WPE build again (69.01 KB, patch)
2019-10-08 17:52 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (69.02 KB, patch)
2019-10-09 17:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-10-08 15:29:27 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2019-10-08 16:10:57 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2019-10-08 16:50:42 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 4 2019-10-08 17:03:28 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 5 2019-10-08 17:37:38 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 6 2019-10-08 17:52:47 PDT
Created attachment 380487 [details] WIP: Try to fix WPE build again
Tim Horton
Comment 7 2019-10-09 17:10:43 PDT
Comment on attachment 380487 [details] WIP: Try to fix WPE build again View in context: https://bugs.webkit.org/attachment.cgi?id=380487&action=review > Source/WebCore/platform/mac/PlatformPasteboardMac.mm:387 > +static NSPasteboardType modernPasteboardTypeForWebSafeMIMEType(const String& webSafeType) Surely we have the MIME type strings somewhere and can use those
Wenson Hsieh
Comment 8 2019-10-09 17:38:06 PDT
Comment on attachment 380487 [details] WIP: Try to fix WPE build again View in context: https://bugs.webkit.org/attachment.cgi?id=380487&action=review Thanks for the review! >> Source/WebCore/platform/mac/PlatformPasteboardMac.mm:387 >> +static NSPasteboardType modernPasteboardTypeForWebSafeMIMEType(const String& webSafeType) > > Surely we have the MIME type strings somewhere and can use those Interestingly, I couldn’t find anything that exposes these strings as constants (though I could imagine them on MIMETypeRegistry or something similar. Perhaps functions in a MIMETypes:: namespace?) For now, I’ll change these string constants to ASCIILiterals instead. I filed webkit.org/b/202776 to track exposing something on MIMETypeRegistry...
Wenson Hsieh
Comment 9 2019-10-09 17:40:25 PDT
Created attachment 380594 [details] Patch for landing
WebKit Commit Bot
Comment 10 2019-10-09 18:27:22 PDT
Comment on attachment 380594 [details] Patch for landing Clearing flags on attachment: 380594 Committed r250950: <https://trac.webkit.org/changeset/250950>
Radar WebKit Bug Importer
Comment 11 2019-10-09 18:48:15 PDT
<rdar://problem/56139814>
Note You need to log in before you can comment on or make changes to this bug.