Bug 202605

Summary: Socket-based RWI should base64-encode backend commands on client, not server
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2019-10-04 14:47:52 PDT
Socket-based RWI should base64-encode backend commands on client, not server
Attachments
Patch (3.38 KB, patch)
2019-10-04 14:48 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-10-04 14:48:51 PDT
Created attachment 380253 [details] Patch
Ross Kirsling
Comment 2 2019-10-04 14:52:21 PDT
Just a follow-up to r250679 that was based on a misunderstanding on my part. (Either way technically works, but I'd gone out of my way to do this on the server, when I'd forgotten that base64 encoding text *increases* the size... 🤦‍♂️)
WebKit Commit Bot
Comment 3 2019-10-04 15:24:02 PDT
Comment on attachment 380253 [details] Patch Clearing flags on attachment: 380253 Committed r250752: <https://trac.webkit.org/changeset/250752>
WebKit Commit Bot
Comment 4 2019-10-04 15:24:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-10-04 15:25:16 PDT
<rdar://problem/55997224>
Note You need to log in before you can comment on or make changes to this bug.