Bug 202597

Summary:

Clean up: Remove pre-macOS Sierra workaround for missing kVK_RightCommand

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2019-10-04 13:00:14 PDT

Since macOS High Sierra kVK_RightCommand has been HIToolbox/Events.h. It wasn't defined in the macOS Sierra days. We don't build for macOS Sierra any longer and can remove the workaround.

Attachments
Patch (1.49 KB, patch) 2019-10-04 13:04 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2019-10-04 13:03:28 PDT

Actually this constant has been around since macOS Sierra – as the comment in the code stated.

Daniel Bates

Comment 2 2019-10-04 13:04:20 PDT

Created attachment 380238 [details] Patch

Daniel Bates

Comment 3 2019-10-05 11:13:11 PDT

Thanks Anders

Daniel Bates

Comment 4 2019-10-09 10:24:07 PDT

Comment on attachment 380238 [details] Patch Clearing flags on attachment: 380238 Committed r250915: <https://trac.webkit.org/changeset/250915>

Daniel Bates

Comment 5 2019-10-09 10:24:09 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-10-09 10:25:16 PDT

<rdar://problem/56120950>

Note You need to log in before you can comment on or make changes to this bug.