Bug 202578 – A service worker process should not be created when enqueuing a service worker job

• Component: Service Workers
• Status: RESOLVED FIXED

[youenn fablet]

This is too early.
In some cases, the jobs will never need the service worker process.

[Radar WebKit Bug Importer]

<rdar://problem/55979690>

[youenn fablet]

Created attachment 380213 [details]
Patch

[Chris Dumez]

Comment on attachment 380213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380213&action=review

> Source/WebKit/ChangeLog:3
> +        A service worker process should not be created when enqueuing a service worker job

In what cases are we running a job but won't need a service worker process? Are those cases really common? Won't there be a potential performance cost to your change in the common case where we will end up needing this service worker process (since you are now effectively delaying its launch)?

[youenn fablet]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 380213 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380213&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        A service worker process should not be created when enqueuing a service worker job
> 
> In what cases are we running a job but won't need a service worker process?

There is some information in the rdar about that.
We only need the process for jobs that will end up installing a service worker.

> Are those cases really common? Won't there be a potential performance cost
> to your change in the common case where we will end up needing this service
> worker process (since you are now effectively delaying its launch)?

We do not delay anything for time sensitive cases (fetch and postMessage).
We slightly delay for the install case but I do not think this step is very time sensitive since it already requires grabbing a script, running it, calling a bunch of service worker event handlers...

[youenn fablet]

Ping review

[WebKit Commit Bot]

Comment on attachment 380213 [details]
Patch

Clearing flags on attachment: 380213

Committed r250957: <https://trac.webkit.org/changeset/250957>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.