Summary: | [GTK] Crash in WebChromeClient::createDisplayRefreshMonitor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, cmarcelo, ews-watchlist, gyuyoung.kim, luiz, magomez, noam, ryuan.choi, sergio, zan, zeno | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Michael Catanzaro
2019-10-03 17:12:57 PDT
Created attachment 380206 [details]
Patch
Comment on attachment 380206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380206&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:213 > + if (!m_rootLayer && !isFlushingLayerChanges()) wouldn't this be if (m_rootLayer && !isFlushingLayerChanges())? As the should only notify if the root layer is still alive. Comment on attachment 380206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380206&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:71 > + ASSERT(!m_rootLayer); Where does this get nulled out now, in a way that it would make the assertion succeed? Comment on attachment 380206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380206&action=review >> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:71 >> + ASSERT(!m_rootLayer); > > Where does this get nulled out now, in a way that it would make the assertion succeed? In invalidate(). >> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:213 >> + if (!m_rootLayer && !isFlushingLayerChanges()) > > wouldn't this be if (m_rootLayer && !isFlushingLayerChanges())? As the should only notify if the root layer is still alive. Oops, indeed, good catch! Created attachment 380210 [details]
Updated patch
Comment on attachment 380210 [details]
Updated patch
Didn't see CompositingCoordinator::invalidate() before.
Committed r250717: <https://trac.webkit.org/changeset/250717> |