Bug 202544 – Replace _WKProcessPoolConfiguration.suppressesConnectionTerminationOnSystemChange with SPI on _WKWebsiteDataStoreConfiguration

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Replace _WKProcessPoolConfiguration.suppressesConnectionTerminationOnSystemChange with SPI on _WKWebsiteDataStoreConfiguration

[Alex Christensen]

Created attachment 380156 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r250677

[Radar WebKit Bug Importer]

<rdar://problem/55960800>

Comment on attachment 380156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380156&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:71
> +@property (nonatomic) BOOL suppressesConnectionTerminationOnSystemChange WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

How does this relate to website data?

[Alex Christensen]

It goes in the NSURLSessionConfiguration, which is associated with a data store.

(In reply to Alex Christensen from comment #5)
> It goes in the NSURLSessionConfiguration, which is associated with a data
> store.

Unless I’m missing something, the NSURLSessionConfiguration association is an implementation detail and not part of the API, so that’s not a good motivator for introducing this property on _WKWebsiteDataStoreConfiguration.

[Alex Christensen]

_WKWebsiteDataStoreConfiguration is currently the best place in the API/SPI for the properties that apply to all WKWebViews that share the same networking session.  I've considered adding a network parameters object to the _WKWebsiteDataStoreConfiguration

(In reply to Alex Christensen from comment #7)
> _WKWebsiteDataStoreConfiguration is currently the best place in the API/SPI
> for the properties that apply to all WKWebViews that share the same
> networking session.

It’s not immediately clear why. Does the concept of networking session exist in the API? Is it conceptually related to website data and/or persistence?

[Alex Christensen]

(In reply to mitz from comment #8)
> (In reply to Alex Christensen from comment #7)
> > _WKWebsiteDataStoreConfiguration is currently the best place in the API/SPI
> > for the properties that apply to all WKWebViews that share the same
> > networking session.
> 
> It’s not immediately clear why. Does the concept of networking session exist
> in the API? Is it conceptually related to website data and/or persistence?

A networking session *is* conceptually related to website data because of cookies and the HTTP cache.

[Sam Weinig]

I agree with Mitz here. It doesn't seem like this makes sense as a property of the WebsiteDataStore. For now, it probably makes the most sense on WKWebView itself.

Separately, this name is very opaque. What exactly is "SystemChange" in this context?