Bug 202536

Summary: Simplify sandbox enabling macros
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Alex Christensen
Reported 2019-10-03 10:47:13 PDT
Simplify sandbox enabling macros
Attachments
Patch (54.89 KB, patch)
2019-10-03 10:52 PDT, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-10-03 10:52:29 PDT
Created attachment 380136 [details] Patch
Brent Fulgham
Comment 2 2019-10-03 13:21:15 PDT
Comment on attachment 380136 [details] Patch Looks reasonable. It might be worth double-checking with mitz or weinig to make sure we aren't missing something.
Brent Fulgham
Comment 3 2019-10-03 13:22:17 PDT
The patch looks okay to me, but I don't remember the reason for the "manual sandboxing" flow. I think this was very old stuff from when iOS was being brought up but I'm CC'ing some people who might remember the history in case we are about to break something important.
Alexey Proskuryakov
Comment 4 2019-10-03 15:49:47 PDT
Yes, manual sandboxing was about entering sandbox from our own code (similar to how it's done on macOS), and was only needed at early stages of development.
Alex Christensen
Comment 5 2019-10-04 08:33:47 PDT
http://trac.webkit.org/r250723
Radar WebKit Bug Importer
Comment 6 2019-10-04 08:34:19 PDT
<rdar://problem/55983554>
Note You need to log in before you can comment on or make changes to this bug.