Bug 20252

Summary: make install does not install WebKitAvailability.h
Product: WebKit Reporter: Rob Gowin <robg>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch to add header to JavaScriptCore/GNUmakefile.am
eric: review-
Patch with tabs instead of spaces. eric: review+

Rob Gowin
Reported 2008-08-01 07:34:44 PDT
When doing a 'make install', the file JavaScriptCore/API/WebKitAvailability.h is not copied to $(prefix)/include/webkit-1.0/JavaScriptCore. This include file is referenced from JSContextRef.h. I using svn version 35511. My analysis so far: When automake creates GNUmakefile.in, the javascriptcore_h_api variable does not have WebKitAvailability.h in the list of headers. My automake-fu is not up to the task of determining how this list is generated. (The javascriptcore_h_api variable is empty in GNUmakefile.am). This causes pywebkitgtk to fail to compile.
Attachments
Patch to add header to JavaScriptCore/GNUmakefile.am (1.05 KB, patch)
2008-08-01 09:43 PDT, Rob Gowin 		eric: review-
DetailsFormatted DiffDiff
Patch with tabs instead of spaces. (1.05 KB, patch)
2008-08-01 12:27 PDT, Rob Gowin 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Gowin
Comment 1 2008-08-01 09:43:09 PDT
Created attachment 22601 [details] Patch to add header to JavaScriptCore/GNUmakefile.am Patch to add JavaScriptCore/API/WebKitAvailability.h to JavaScriptCore/GNUmakefile.am, with ChangeLog entry.
Eric Seidel (no email)
Comment 2 2008-08-01 12:20:38 PDT
Comment on attachment 22601 [details] Patch to add header to JavaScriptCore/GNUmakefile.am You patch uses spaces, the rest of that file uses tabs.
Rob Gowin
Comment 3 2008-08-01 12:27:01 PDT
Created attachment 22606 [details] Patch with tabs instead of spaces. Redo patch with tabs instead of spaces.
Eric Seidel (no email)
Comment 4 2008-08-01 15:11:45 PDT
Comment on attachment 22606 [details] Patch with tabs instead of spaces. Looks great. Thanks.
Jan Alonzo
Comment 5 2008-08-02 18:48:12 PDT
landed in r35531
Note You need to log in before you can comment on or make changes to this bug.