Bug 202502 – Fix a bug that warning icon causes infinite rendering when it has warning message.

• Component: New Bugs
• Status: RESOLVED FIXED

Fix a bug that warning icon causes infinite rendering when it has warning message.

Created attachment 380071 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 380071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380071&action=review

> Websites/perf.webkit.org/public/v3/components/warning-icon.js:4
>      {

I didn't catch this when this class was initially added but it's probably not a good idea to set the warning message in the constructor.
We should just add a member function which sets the warning message.
Then we can simply forward it to this.setButtonTitle, which would avoid this problem without having to create a LazilyEvaluatedFunction.

> Websites/perf.webkit.org/public/v3/components/warning-icon.js:10
> +    _renderWarningMessage(warningMessage)

We usually define these after render().

Created attachment 380080 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 380080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380080&action=review

> Websites/perf.webkit.org/public/v3/components/test-group-revision-table.js:122
> +            warningIcon.setButtonTitle(`Last status: ${request.statusDescription()}`);

It's a bit strange to call setButtonTitle on WarningIcon.
I think we should add a method like setWarning on WarningIcon itself, which is a trivial forwarding to setButtonTitle.

Landed in r250647.