Bug 202453

Summary: Gardening build fix: Hide store64/load64 functions from 32bit
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: New BugsAssignee: Paulo Matos <pmatos>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, guijemont, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Paulo Matos
Reported 2019-10-02 04:58:50 PDT
Hide store64/load64 functions from 32bit
Attachments
Patch (1.76 KB, patch)
2019-10-02 05:01 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2019-10-02 05:22 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2019-10-02 05:57 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Paulo Matos
Comment 1 2019-10-02 05:01:47 PDT
Created attachment 380010 [details] Patch
Paulo Matos
Comment 2 2019-10-02 05:04:59 PDT
Caused by patch for bug 202250.
Paulo Matos
Comment 3 2019-10-02 05:22:29 PDT
Created attachment 380011 [details] Patch
WebKit Commit Bot
Comment 4 2019-10-02 05:26:33 PDT
Comment on attachment 380011 [details] Patch Rejecting attachment 380011 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 380011, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13087231
Paulo Matos
Comment 5 2019-10-02 05:57:03 PDT
Created attachment 380012 [details] Patch
WebKit Commit Bot
Comment 6 2019-10-02 06:51:18 PDT
Comment on attachment 380012 [details] Patch Clearing flags on attachment: 380012 Committed r250604: <https://trac.webkit.org/changeset/250604>
WebKit Commit Bot
Comment 7 2019-10-02 06:51:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-02 06:52:17 PDT
<rdar://problem/55908314>
Note You need to log in before you can comment on or make changes to this bug.