Bug 202439

Summary: Remove SVGPropertyState from SVGProperty
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW    
Severity: Normal CC: dino, ews-watchlist, fmalita, gyuyoung.kim, pdr, schenney, sergio, simon.fraser, thorton, zimmermann
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for review
none
Patch sabouhallawa: review?

Said Abou-Hallawa
Reported 2019-10-01 16:47:45 PDT
Instead of having SVGElement asks the SVGProperty to set its state to be dirty, we are going to keep a HashSet<QualifiedName> in SVGElement to tell which attributes have to be re-serialized.
Attachments
Patch (61.91 KB, patch)
2019-10-01 16:49 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (21.26 KB, patch)
2019-10-01 17:01 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (21.16 KB, patch)
2019-10-30 11:59 PDT, Said Abou-Hallawa 		sabouhallawa: review?
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-10-01 16:49:04 PDT
Created attachment 379966 [details] Patch
Said Abou-Hallawa
Comment 2 2019-10-01 17:01:08 PDT
Created attachment 379971 [details] Patch for review
Nikolas Zimmermann
Comment 3 2019-10-02 02:51:34 PDT
Another nice cleanup! Thanks for revisiting the svg/properties/* design, this is really much easier to follow now.
Said Abou-Hallawa
Comment 4 2019-10-30 11:59:28 PDT
Created attachment 382338 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-11-12 16:43:04 PST
Comment on attachment 382338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382338&action=review > Source/WebCore/svg/SVGElement.h:195 > + HashSet<QualifiedName> m_dirtyAttributes; Does every SVGElement need a HashSet? This has memory impact for something which most elements won't use. Maybe store it in a static hash map?
Note You need to log in before you can comment on or make changes to this bug.