Bug 202412

Summary: Negative radii in radial gradients should be rejected.
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: CSSAssignee: Joonghun Park <jh718.park>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jh718.park, koivisto, macpherson, megan_gardner, menard, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Emilio Cobos Álvarez (:emilio) 2019-10-01 11:16:58 PDT
Per https://drafts.csswg.org/css-images/#valdef-size-length:

>  Gives the radius of the circle explicitly. Negative values are invalid. 

Other browsers also suffered from the same issue, but they're being fixed.

Chromium:

 * https://bugs.chromium.org/p/chromium/issues/detail?id=1008112
 * https://bugs.chromium.org/p/chromium/issues/detail?id=978790

Gecko:

 * https://bugzilla.mozilla.org/show_bug.cgi?id=1583736
Comment 1 Radar WebKit Bug Importer 2019-10-02 13:38:42 PDT
<rdar://problem/55922449>
Comment 2 Joonghun Park 2019-10-04 08:16:54 PDT
Created attachment 380222 [details]
Patch
Comment 3 Antti Koivisto 2019-10-04 09:23:33 PDT
Comment on attachment 380222 [details]
Patch

r=me
Comment 4 Joonghun Park 2019-10-04 09:43:41 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 380222 [details]
> Patch
> 
> r=me

Thank you for your review, Antti:)
Comment 5 WebKit Commit Bot 2019-10-04 10:30:23 PDT
Comment on attachment 380222 [details]
Patch

Clearing flags on attachment: 380222

Committed r250730: <https://trac.webkit.org/changeset/250730>
Comment 6 WebKit Commit Bot 2019-10-04 10:30:24 PDT
All reviewed patches have been landed.  Closing bug.