Bug 202409

Summary: [CSS Shadow Parts] Parse 'part' attribute
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kangil.han, kondapallykalyan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149443    
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch
rniwa: review+
patch none

Antti Koivisto
Reported 2019-10-01 10:17:08 PDT
Element.part
Attachments
patch (19.15 KB, patch)
2019-10-01 10:27 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (19.23 KB, patch)
2019-10-01 10:48 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (19.85 KB, patch)
2019-10-01 11:44 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (20.41 KB, patch)
2019-10-01 13:40 PDT, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
patch (20.50 KB, patch)
2019-10-01 14:21 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-10-01 10:27:20 PDT
Created attachment 379913 [details] patch
Antti Koivisto
Comment 2 2019-10-01 10:48:33 PDT
Created attachment 379915 [details] patch
Antti Koivisto
Comment 3 2019-10-01 11:44:36 PDT
Created attachment 379918 [details] patch
Antti Koivisto
Comment 4 2019-10-01 13:40:12 PDT
Created attachment 379943 [details] patch
Ryosuke Niwa
Comment 5 2019-10-01 13:41:07 PDT
Comment on attachment 379918 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=379918&action=review > Source/WebCore/dom/Element.cpp:1722 > + else if (name == HTMLNames::partAttr) Check the runtime flag here?
Ryosuke Niwa
Comment 6 2019-10-01 13:41:30 PDT
Comment on attachment 379943 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=379943&action=review > Source/WebCore/dom/Element.cpp:1723 > + else if (name == HTMLNames::partAttr) > + partAttributeChanged(newValue); Add a runtime check?
Antti Koivisto
Comment 7 2019-10-01 14:21:11 PDT
Created attachment 379949 [details] patch
Antti Koivisto
Comment 8 2019-10-01 15:03:24 PDT
> Add a runtime check? Done.
WebKit Commit Bot
Comment 9 2019-10-01 15:48:04 PDT
Comment on attachment 379949 [details] patch Clearing flags on attachment: 379949 Committed r250584: <https://trac.webkit.org/changeset/250584>
WebKit Commit Bot
Comment 10 2019-10-01 15:48:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-10-01 15:49:17 PDT
<rdar://problem/55893049>
Note You need to log in before you can comment on or make changes to this bug.